Task 7 #509
Open
Task 7 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anddrews
reviewed
Apr 21, 2024
| @@ -31,6 +31,9 @@ export default function CSVFileImport({ url, title }: CSVFileImportProps) { | |||
| } | |||
| const response = await axios({ | |||
| method: "GET", | |||
| headers: { | |||
There was a problem hiding this comment.
I suggest using axios.interceptors to prevent nessesety to add authorization for every request manually
| @@ -48,7 +48,7 @@ export function useRemoveProductCache() { | |||
|
|
|||
| export function useUpsertAvailableProduct() { | |||
| return useMutation((values: AvailableProduct) => | |||
| axios.put<AvailableProduct>(`${API_PATHS.bff}/product`, values, { | |||
| axios.post<AvailableProduct>(`${API_PATHS.bff}/products`, values, { | |||
| headers: { | |||
| Authorization: `Basic ${localStorage.getItem("authorization_token")}`, | |||
There was a problem hiding this comment.
The same as above for authorization's header
There was a problem hiding this comment.
Headers is not my code, I have no reason to change it in scope of my task
|
It looks to weird you made a PR into the common repo, not your local fork. |
seneka-epam13
force-pushed
the
task-7
branch
2 times, most recently
from
6d82883 to
9e5a538
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You should add key:value to local storage
key: authorization_token
value: Basic c2VuZWthX2VwYW0xMzpURVNUX1BBU1NXT1JE