Dev asyn motor remove init event #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkRivers
reviewed
Oct 9, 2020
motorApp/MotorSrc/devMotorAsyn.c
Outdated
| pmr->name, setPos ); | ||
| } else { | ||
| asynPrint(pasynUser, ASYN_TRACE_FLOW, | ||
| "devMotorAsyn::init_controller, %s set position to %f\n", | ||
| "devMotorAsyn::init_controller, %s set position to %2.6lf\n", |
There was a problem hiding this comment.
%lf is not a correct format for printf(). It should just be %f. I don't think we should be giving precision and width, we don't know the magnitude of these values.
There was a problem hiding this comment.
Thanks for the review, @MarkRivers
I agree that the %f should be the default for a generic code base.
A new version had been pushed.
Unless we introduce a macro/#define and make the configurable, but that is another story.
There was a problem hiding this comment.
Please see even the version for upstream motor:
epics-modules/motor#167
When the motorRecord is initialized, init_record() is called. For asynMotors init_record() calls init_controller() in devMotorAsyn.c From here, the encoder ratio is send to the driver. After doing that, the code "locks" the execution waiting for a callback to call epicsEventSignal(pPvt->initEvent) which "unlocks" the code. As Mark Clift points out, this code can be simplified and the initEvent can be removed. Mark Rivers suggested to use the asynFloat64SyncIO interface, which locks the asyn port when calling the driver.
…nitEvent
Conflicts:
motorApp/MotorSrc/devMotorAsyn.c
tboegi
force-pushed
the
dev-asynMotor-remove-initEvent
branch
from
0595f69 to
8dee7bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.