Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NPC charming a PC #947

Open
huffin opened this issue Jan 19, 2020 · 0 comments
Open

NPC charming a PC #947

huffin opened this issue Jan 19, 2020 · 0 comments
Labels
Bug Needs Investigation

Comments

@huffin
Copy link
Contributor

huffin commented Jan 19, 2020 •
edited
Loading

Currently it is very easy to make an NPC faction war happen. These are some parsed mechanics that need to be implemented to make NPC charm function more accurately and reduce how easy it is to get NPCs to attack each other.

1.) If after you are charmed, and another spell was already being cast by a different NPC, then that spell lands on you while you are now charmed, that NPC will continue to attack you, it will call for assist (minus the mob that charmed you) and they kill you, you do not fight back, aggro is not transferred to owner NPC.

The main issue with how number 1 currently functions on PEQ is that aggro transfers from the charmed PC to the owner NPC way too easily which starts an instant faction war.
@dencelle dencelle mentioned this issue May 18, 2021
Merged
RoT-PvP pushed a commit to RoT-PvP/Server that referenced this issue May 18, 2021
@dencelle @RoT-PvP
[Bug Fix] NPC not breaking charm correctly
3ef1923 
EQEmu#947 and EQEmu#905
fixes the issue with charm breaking and spells being cast after to cause a faction war. this removes dots to stop faction wars also.

dot removal part needs better testing to ensure it works as intended
Akkadius added a commit that referenced this issue Jun 11, 2021
@dencelle @Akkadius
[Bug Fix] NPC not breaking charm correctly (#1363)
f0bf382 
* [Bug Fix] NPC not breaking charm correctly

#947 and #905
fixes the issue with charm breaking and spells being cast after to cause a faction war. this removes dots to stop faction wars also.

dot removal part needs better testing to ensure it works as intended

* Remove this-> since it is implied

* Update spell_effects.cpp

* clear all this->

* pMob to mob

* Added rule Spells:PreventFactionWarOnCharmBreak

Co-authored-by: Chris Miles <akkadius1@gmail.com>
@Kinglykrab Kinglykrab changed the title NPC charming a PC: bugs NPC charming a PC Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Needs Investigation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huffin @Kinglykrab