[Repositories] Add expedition repositories #1223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgtw
approved these changes
Feb 6, 2021
ghost
approved these changes
Feb 6, 2021
hgtw
reviewed
Feb 6, 2021
| int character_id; | ||
| std::string expedition_name; | ||
| std::string event_name; | ||
| std::string expire_time; |
There was a problem hiding this comment.
It should generate a time_t for DATETIME fields instead of a string
| entry.character_id = 0; | ||
| entry.expedition_name = ""; | ||
| entry.event_name = ""; | ||
| entry.expire_time = current_timestamp(); |
There was a problem hiding this comment.
I don't see this method in the source, maybe an artifact from the autogen for DATETIME columns?
There was a problem hiding this comment.
Not sure where this came from tbh
There was a problem hiding this comment.
It's coming from the MySQL default value column; that's why. Should still probably change how this outputs a bit. Easy enough to change either way
There was a problem hiding this comment.
my $default_value = 0;
if ($column_default ne "NULL" && $column_default ne "") {
$column_default =~ s/'/"/g;
$default_value = $column_default;
}
elsif ($column_default eq "''") {
$default_value = '""';
}
elsif ((trim($column_default) eq "" || $column_default eq "NULL") && $column_type =~ /text|varchar/i) {
$default_value = '""';
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.