Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Do not summon pet or set new pet state when PC summoned by a mob #1272

Merged
merged 2 commits into from
Mar 6, 2021

Conversation

noudess
Copy link
Contributor

@noudess noudess commented Feb 25, 2021

This is in response to the discussion in eqemu-coders:

https://discord.com/channels/212663220849213441/557677602706423982/814234259845283870

The "fix" is simple. From what I read, the pet does not switch from guard to follow on live. I did not check live myself, I'm relying on the information in the thread.

If the pet should stay on guard, this should fix the issue.

@noudess noudess requested review from mackal and Akkadius February 25, 2021 12:42
@noudess
Copy link
Contributor Author

noudess commented Feb 25, 2021

One thought I had, was if summon was GM solicited to add this back in.

Let me know and I can do that below where it checks zone mode.

@mackal
Copy link
Member

mackal commented Feb 25, 2021

Pet shouldn't be moved either, it should stay in place

@noudess
Copy link
Contributor Author

noudess commented Feb 25, 2021

Pet shouldn't be moved either, it should stay in place

Ok. What about a GM summons? Shall I just move the code to only occur in that instance?

You realize that once PC is attacked after summons, pet will travel to assist PC? I agree this is correct, just stating it 'cause perhaps that's why someone added this to begin with.

@mackal
Copy link
Member

mackal commented Feb 25, 2021

Pet shouldn't be moved either, it should stay in place

Ok. What about a GM summons? Shall I just move the code to only occur in that instance?

You realize that once PC is attacked after summons, pet will travel to assist PC? I agree this is correct, just stating it 'cause perhaps that's why someone added this to begin with.

I'm not sure on the 100% correctly behavior. My pet 100% did not get automoved when I took a portal when my pet was on guard. Does the pet move on live when they have hold and guard on? Or is it because they're moving to attack?

@noudess
Copy link
Contributor Author

noudess commented Feb 25, 2021

Pet shouldn't be moved either, it should stay in place

Ok. What about a GM summons? Shall I just move the code to only occur in that instance?
You realize that once PC is attacked after summons, pet will travel to assist PC? I agree this is correct, just stating it 'cause perhaps that's why someone added this to begin with.

I'm not sure on the 100% correctly behavior. My pet 100% did not get automoved when I took a portal when my pet was on guard. Does the pet move on live when they have hold and guard on? Or is it because they're moving to attack?

They will start to come as soon as PC is attacked actually, so all we're doing is removing the instamove. I think you're right that the move be removed. My only question is, shall we do the move and follow if its a GM summons.

@noudess
Copy link
Contributor Author

noudess commented Feb 25, 2021

After further investigation, things like evac need to move the pet and set follow.

I will look at each type of zm and test and post something that covers them all.

Please hold on approval.

@noudess
Copy link
Contributor Author

noudess commented Feb 25, 2021

Ok. I like this solution better. It fixes the problem that is being seen by players without impacting all the other cases like evac, succor, etc.

@noudess noudess changed the title Don't take pet guard off when PC is summoned BUG FIX: Do not summon pet or set new pet state when PC summoned by a mob Feb 27, 2021
@ghost ghost changed the title BUG FIX: Do not summon pet or set new pet state when PC summoned by a mob [Bug Fix] Do not summon pet or set new pet state when PC summoned by a mob Feb 27, 2021
@KimLS KimLS merged commit af82a6c into EQEmu:master Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants