[Cleanup] Only link Lua with zone #1288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only zone requires to be linked to lua, so let's not link EVERYTHING. There is probably more clean up we could do, but I know for a fact Lua is only used by zone. This probably has some measurable benefits that probably don't really matter that much :)
mackal
commented
Mar 7, 2021
| @@ -348,6 +348,8 @@ IF(UNIX) | |||
| ENDIF() | |||
| ENDIF() | |||
|
|
|||
| SET(ZONE_LIBS ${ZONE_LIBS} ${SERVER_LIBS}) | |||
There was a problem hiding this comment.
I had no issues with this line when lua was disabled. So I think it's fine.
Akkadius
approved these changes
Mar 16, 2021
|
LGTM; can get @KimLS to take a quick look before merging if you want |
KimLS
approved these changes
Mar 19, 2021
|
Looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only zone requires to be linked to lua, so let's not link EVERYTHING.
There is probably more clean up we could do, but I know for a fact Lua
is only used by zone.
This probably has some measurable benefits that probably don't really
matter that much :)