Added a check to stop Bard song for Mezz/Stun #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joligario
reviewed
Apr 1, 2021
I'm fairly new to coding and PRs specifically. Any tips or could you further explain exactly what you mean? This is works for my server currently. |
if ((IsStunned() && bardsong != 0) || (IsMezzed() && bardsong != 0)) {is what @joligario was saying it should be, but we can shorten this if (bardsong != 0 && (IsStunned() || IsMezzed())) { |
joligario
approved these changes
Apr 1, 2021
mackal
approved these changes
Apr 1, 2021
mackal
suggested changes
Apr 1, 2021
There was a problem hiding this comment.
Okay, after testing on live, a bard holding a song will not always be interrupted when they are stunned. I think fixing whatever is going wrong with stun at https://github.com/EQEmu/Server/blob/master/zone/spells.cpp#L4923 is a better fix. Probably just need to add some bardsong checks I guess since just the plain InterruptSpell() call isn't cutting it. the Mob::Mesmerize() function probably needs tweaking as well.
mackal
approved these changes
Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.