Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Quest API] Add HTML color tag method to Perl and Lua. #1324

Merged
merged 3 commits into from
Apr 23, 2021
Merged

[Quest API] Add HTML color tag method to Perl and Lua. #1324

merged 3 commits into from
Apr 23, 2021

Conversation

ghost
Copy link

@ghost ghost commented Apr 8, 2021

  • Add quest::gethexcolorcode(color_name) to Perl.
  • Add eq.get_hex_color_code(color_name) to Lua.

Color name is case-insensitive.

Full color list here: https://pastebin.com/rUYKr1ye

@Kinglykrab
Add HTML color tag method to Perl and Lua.
e671f85 
- Add quest::gethexcolorcode(color_name) to Perl.
- Add eq.get_hex_color_code(color_name) to Lua.

Full color list here: https://pastebin.com/rUYKr1ye
hgtw
hgtw approved these changes Apr 17, 2021
View reviewed changes
Copy link
Contributor

@hgtw hgtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also an alternative to looping the map is to give the map a case-insensitive comparator and doing normal lookups. Performance difference probably doesn't matter all that much in a quest api though

zone/questmgr.cpp Outdated Show resolved Hide resolved
zone/questmgr.cpp Outdated Show resolved Hide resolved
@Akkadius Akkadius changed the title Add HTML color tag method to Perl and Lua. [Quest API] Add HTML color tag method to Perl and Lua. Apr 23, 2021
@Akkadius Akkadius merged commit 13a50f7 into master Apr 23, 2021
@ghost ghost deleted the get_color_tag branch April 23, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mackal @Akkadius @hgtw @Kinglykrab