[Boats] Prevent client update while on boat if boat turning #1343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
approved these changes
May 4, 2021
|
In the game the patch works very well. After 2 hours of boating with three accounts I could not notice any problems. |
Akkadius
approved these changes
May 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates for client positions while a client is on a boat are received as x/y offsets based on the boats current heading.
When the server rotates the boat, it updates Heading in the boat server instance. This means all future updates from the client will be processed according to that new heading.
Since the server only approximates rotation progress, there will be errors if we use client updates for PCs on boats while the boat is turning.
This patch tosses out the updates for the client while the boat he/she is on is turning, eliminating that error.