[Spells] Adds a rule to allow right-click memorize from spell scrolls. #1377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
spell_scroll_scribe
branch
from
08075d2 to
b215fb0
Compare
This comment was marked as abuse.
This comment was marked as abuse.
splose
approved these changes
Jun 6, 2021
mackal
approved these changes
Jun 8, 2021
hgtw
approved these changes
Jun 8, 2021
Akkadius
reviewed
Jun 11, 2021
| return false; | ||
| } | ||
|
|
||
| if(!( |
There was a problem hiding this comment.
Not necessarily requesting changes here for this PR but converting the char array to a std::string would make it easy to do a string find and simplify the code a bit
Example
std::string item_name = item->Name;
if (item_name.find("Spell: ") != std::string::npos) {
std::cout << "found!" << '\n';
}
Akkadius
reviewed
Jun 11, 2021
| @@ -509,6 +509,87 @@ bool Client::TrainDiscipline(uint32 itemid) { | |||
| return(false); | |||
| } | |||
|
|
|||
| bool Client::MemorizeSpellFromItem(uint32 item_id) { | |||
| const EQ::ItemData *item = database.GetItem(item_id); | |||
There was a problem hiding this comment.
Could have used auto here; but the explicitness is good too
Akkadius
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses similar logic to disciplines with the hardcoded
Tome:check and stuff, but withSpell:items here instead. Locked it behind a rule in case people don't want to use it.