Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pets] Unhardcode Beastlord pet values. #1379

Merged
merged 2 commits into from
Jun 11, 2021
Merged

[Pets] Unhardcode Beastlord pet values. #1379

merged 2 commits into from
Jun 11, 2021

Conversation

ghost
Copy link

@ghost ghost commented Jun 6, 2021

  • Create a Beastlord pets table to allow server operators to easily customize Beastlord pets without a source modification.
  • Defaults to similar values as the original switch inside the struct and database table.

@ghost ghost force-pushed the beastlord_pets branch 2 times, most recently from 4764327 to a3bb891 Compare June 6, 2021 18:26
- Create a Beastlord pets table to allow server operators to easily customize Beastlord pets without a source modification.
@ghost ghost force-pushed the beastlord_pets branch from a3bb891 to f0668b9 Compare June 6, 2021 18:27
@mackal
Copy link
Member

mackal commented Jun 8, 2021

Seems reasonable, but I want @Akkadius to review it

@mackal mackal requested a review from Akkadius June 8, 2021 16:42
Copy link
Contributor

@hgtw hgtw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pets_beastlord_data table will need added to common/database_schema.h content tables list also

Copy link
Member

@Akkadius Akkadius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very nice quality of life change for many server operators who've made tweaks for this in the past :buff:

KingMort has done this, Dhaymion from Lazarus has done this as well as others

It will be nice to have this driven from the source

I like the DTO pattern around using a struct to hydrate the database data; only thing I would suggest is generating a repository for this new table to do the same thing in the future and you don't have to manually wire any of this up next time

We have a generator script for this if you're interested in diving in, it just generates directly from your database table schema data https://eqemu.gitbook.io/server/in-development/developer-area/repositories

We have a lot of opportunity in our code to simplify bloat by converting over to using repositories

@Akkadius Akkadius merged commit b87c548 into master Jun 11, 2021
@ghost ghost deleted the beastlord_pets branch June 12, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants