Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Commands] Add #viewzoneloot [item id] command. #1382

Merged
merged 3 commits into from
Jun 12, 2021
Merged

Conversation

ghost
Copy link

@ghost ghost commented Jun 11, 2021

  • Allows GMs to search for a specific item across all the loot currently available on the spawned NPCs in the zone.
  • Specifying item ID 0 will allow GMs to see all the droppable items, I tested in Sanctus Seru (a huge zone) and it sent approximately 1,200 messages, which didn't lag or desync my client.

- Allows GMs to search for a specific item across all the loot currently available on the spawned NPCs in the zone.
- Specifying item ID 0 will allow GMs to see all the droppable items, I tested in Sanctus Seru (a huge zone) and it sent approximately 1,200 messages, which didn't lag or desync my client.
zone/command.cpp Outdated Show resolved Hide resolved
zone/command.cpp Outdated Show resolved Hide resolved
zone/npc.h Outdated Show resolved Hide resolved
@ghost ghost force-pushed the command_viewzoneloot branch from 26b5218 to 27ac20d Compare June 11, 2021 04:01
zone/command.cpp Outdated Show resolved Hide resolved
zone/command.cpp Outdated Show resolved Hide resolved
@Akkadius
Copy link
Member

Neat function

Left minor comments

Also I'm not sure if aware but there is a new-ish Loot log category that will show what ultimately gets rolled / dropped when NPC's spawn which is very helpful

Obviously this is separate from what your command achieves but worth throwing out there

@ghost ghost force-pushed the command_viewzoneloot branch from 44502db to 5b34213 Compare June 11, 2021 23:38
@ghost
Copy link
Author

ghost commented Jun 11, 2021

Neat function

Left minor comments

Also I'm not sure if aware but there is a new-ish Loot log category that will show what ultimately gets rolled / dropped when NPC's spawn which is very helpful

Obviously this is separate from what your command achieves but worth throwing out there

Yeah, I'm aware of the log type, someone had specifically requested a command to view the current loot available in the zone.

All comments should be addressed and ready for merge.

@Akkadius Akkadius merged commit 6e12d2f into master Jun 12, 2021
@ghost ghost deleted the command_viewzoneloot branch June 12, 2021 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants