Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Mods] Added Hastev3Cap #1506

Merged
merged 2 commits into from
Sep 4, 2021
Merged

[Mods] Added Hastev3Cap #1506

merged 2 commits into from
Sep 4, 2021

Conversation

xackery
Copy link
Contributor

@xackery xackery commented Aug 26, 2021

Adds hastev3 as a rule

@xackery
Copy link
Contributor Author

xackery commented Aug 26, 2021

I can add an entry to db if desired too. Since overhaste has been capped at 25% in source for 7 years, though, I don't think the demand for increasing it is too significant except on custom servers. Uncofirmed if client displays haste properly, but #mystats is fine.

@mackal
Copy link
Member

mackal commented Aug 26, 2021

I left it hardcoded because that's what the client does. I don't see too much of an issue with a rule, but the client is 100% hardcapped at 25, regardless of the existence of spells that have a 30 here 📦

You also need to update

int Mob::GetHaste()
(I have no good answer to why we have 2 functions, probably double check bots too because reasons)

Copy link
Member

@mackal mackal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed other haste functions that probably shouldn't exist but should.

@xackery
Copy link
Contributor Author

xackery commented Aug 27, 2021

Reviewed bots, seems it is just calling GetHaste() from mob.

@xackery xackery requested a review from mackal August 27, 2021 13:04
@Akkadius Akkadius changed the title Added Hastev3Cap [Mods] Added Hastev3Cap Aug 30, 2021
@Akkadius Akkadius requested a review from KayenEQ August 31, 2021 05:33
Copy link
Contributor

@KayenEQ KayenEQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@Akkadius Akkadius merged commit af6d344 into master Sep 4, 2021
@xackery xackery deleted the xackery/hastev3 branch September 4, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants