-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest Schema Additions #78
Open
fryguy503
wants to merge
1
commit into
main
Choose a base branch
from
trust/manifest_schema
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,10 +29,16 @@ ADD COLUMN `id` int(11) NOT NULL AUTO_INCREMENT FIRST, | |
DROP PRIMARY KEY, | ||
ADD PRIMARY KEY (`id`) USING BTREE, | ||
ADD UNIQUE INDEX(`varname`); | ||
)" | ||
)", | ||
.content_schema_update = false, | ||
.force_interactive = true | ||
}, | ||
``` | ||
|
||
### Optional fields: | ||
- `.content_schema_update` - If true, this will update the content_db if configured | ||
- `.force_interactive` - If true, this will require the user during the migration to consent to the upgrade to move forward as it could be risky or breaking changes. | ||
|
||
That's it! As far as what is needed from a developer to have the server run the migration, that is all you need to do. | ||
|
||
You can test it by running world manually after you compile. Please test your database migrations before submitting a PR, it's a very simple mistake to avoid trying to fix later. | ||
|
@@ -50,3 +56,11 @@ You can test it by running world manually after you compile. Please test your da | |
// std::string sql{}; // the SQL DDL that gets ran when the condition is true | ||
// }; | ||
``` | ||
|
||
### Match Conditions | ||
|
||
- **contains** = Strings::Contains(r, e.match); | ||
- **match** = e.match; | ||
- **missing** = !Strings::Contains(r, e.match); | ||
- **empty** = r.empty(); | ||
- **not_empty** = !r.empty(); | ||
Comment on lines
+62
to
+66
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Formatting, should be a little bit more descriptive |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should leave this field in all the time, otherwise it often gets forgotten in PR's