python: Provide incumbent solution in callback #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I updated the commit to fix the formatting issue and made a small edit to examples/call_highs_from_python.py |
mathgeekcoder
added a commit
to mathgeekcoder/HiGHS
that referenced
this pull request
Sep 16, 2024
Major highspy update: * changed `highs_linear_expression` to be immutable by default * improved callback support * improved test coverage (99%) * performance and usability enhancements * Support `__iadd__`, `__imul__`, etc. * Updated chain comparison support in immutable setting * `h.val()` can take `highs_linear_expression` * `expr == [lb,ub]` -> `lb <= expr <= ub` syntax * `qsum` * added pretty print `__repr__` and `__str__` * added KeyboardInterrupt support * added user interrupt * fixed slicing issues with numpy and highs * added `resetGlobalScheduler` * released GIL for `Presolve` * fixed issues with deadlock on Windows * fixed MIP solution callback issue * support `getExpr` that creates a `highs_linear_expression` from existing row Should address multiple issues: ERGO-Code#1865, ERGO-Code#1882, ERGO-Code#1888, ERGO-Code#1892, ERGO-Code#1903, ERGO-Code#1904, and perhaps ERGO-Code#1905
|
This should be addressed in PR #1942, which was just merged in latest. There are significant updates to highspy, including callbacks. Please, if possible, pull the updates from the latest branch before we can review/approve this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An accessor for the incumbent solution was already present in the callback data in highspy. But as pointed out in #1856 it was not properly implemented. This PR fixes that.