-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sentinel 1 Stats UDP ported to APEX #36
Conversation
also could you please help me understand the cause of final action failure? |
algorithm_catalog/sentinel1_stats/sentinel1_stats_description.md
Outdated
Show resolved
Hide resolved
algorithm_catalog/sentinel1_stats/sentinel1_stats_description.md
Outdated
Show resolved
Hide resolved
algorithm_catalog/sentinel1_stats/sentinel1_stats_description.md
Outdated
Show resolved
Hide resolved
algorithm_catalog/sentinel1_stats/sentinel1_stats_description.md
Outdated
Show resolved
Hide resolved
algorithm_catalog/sentinel1_stats/sentinel1_stats_description.md
Outdated
Show resolved
Hide resolved
algorithm_catalog/sentinel1_stats/sentinel1_stats_description.md
Outdated
Show resolved
Hide resolved
@jdries The only failing unit tests seems to be related to the process graph not being on the actual repo, which should be resolved after the merge? |
In your benchmark definition you use URL https://raw.githubusercontent.com/ESA-APEX/apex_algorithms/main/openeo_udp/sentinel1_stats.json which does not exist yet as this PR is not merged yet. This raises a bit a problem with this PR based approach at submitting algorithms: in the benchmark definition you have to point to the URL of the UDP, but what should you use? The URL of the feature branch being used to create the PR, or the URL of where the UDP will finally live after merging the PR (main branch)? Two quick solutions:
|
FYI you could point to the following instead in the benchmark definition:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes I think it's fine to merge now
Ok, pushed the button, great to have another algorithm! |
A User Defined Process (UDP) has been created for the Sentinel 1 Stats workflow. Ref: https://github.com/Open-EO/openeo-community-examples/blob/main/python/Sentinel1_Stats/Sentinel1_Stats.ipynb
Included is a generate.py file that generates a process graph and saves it as a .json file. However, this process is not yet published or accessible as a shareable service. Within this file, I adopted the same method for establishing connection as for others
In the algorithm catalog JSON, a link to an OpenEO test result has been provided as a shareable link, for example.
Please note that this link may need to be updated.