Issue 710 JUL Respect LogManager Config #744
Conversation
Updating JUL to check for existing global LogManager configuration prior to applying ESAPI file settings. Adding tests to verify LogManager Configurations are preferred to the ESAPI configurations.
Capturing recomended configuration options for class use.
Updating terminology referencing LogManager configuration to match terms use in LogManager documentation.
Adding startup System.out.println content (logSpecial) if the custom esapi-java-logging.properties file is not being applied to the underlying java LogManager instance.
Attempting to clarify differences between the -D use or System.setProperty for LogManager configuration recommendations.
|
Yes, I think so.
…On Sun, Oct 9, 2022, 8:23 AM jeremiahjstacey ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/java/org/owasp/esapi/logging/java/JavaLogFactory.java
<#744 (comment)>
:
> @@ -48,9 +48,9 @@
* Options for customizing this configuration (in recommended order)
* <ol>
* <li>Consider using the <i>SLF4JLogFactory</i> with a java-logging implementation.</li>
- * <li>Configure java LogManager system properties as defined by the <i>java.util.logging.LogManager</i> API</li>
+ * <li>Configure the runtime startup command to set the desired system properties for the <i>java.util.logging.LogManager</i> instance. EG: <code>-Djava.util.logging.config.file=/custom/file/path.properties</code></li>
@kwwall <https://github.com/kwwall> Do these updates make the intended
difference more clear?
—
Reply to this email directly, view it on GitHub
<#744 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAO6PG2IP27VPSX2U7AFOF3WCK2MLANCNFSM6AAAAAAQ2PAMNI>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@jeremiahjstacey - Dang, I prematurely did 'Resolve conversation' without getting your feedback. Sorry about that. I guess you we can merge this PR and your can add a link to the Javadoc to the new GitHub wiki page in a separate PR. Or, if you want to add a new commit to that for this PR, let me know. I'll hold off merging this until I hear from you how you wish to handle it. |
|
Thanks for the feedback. I will need to refresh my memory on how to interact with the wiki again -- been a little while for that. I've integrated your suggestion into the content and attached the result (above) for safe-keeping until the wiki integration is complete. |
|
@jeremiahjstacey - While the 3 of us should be able to manage the GitHub wiki via git, I have found that it is much easier to just manage it directly from GitHub (unless you have massive updates to multiple pages). Just go to https://github.com/ESAPI/esapi-java-legacy/wiki and click on 'New Page', then give that page a title and copy/paste the contents of you .md file into the main wiki description area. |
Adding reference to ESAPI Wiki page.
|
https://github.com/ESAPI/esapi-java-legacy/wiki/Configuration-Reference:-JavaLogFactory Thanks! That worked great. Javadoc is updated and pushed, but I can certainly adjust the page name if desired. |
|
@jeremiahjstacey - The name of the wiki page is fine by me. Merging. |
2 participants
Closes #710
Updating JUL to check for existing global LogManager configuration prior to applying ESAPI file settings.
Adding tests to verify LogManager Configurations are preferred to the ESAPI configurations.