Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert F-compsets to use stub glacier instead of CISM%NOEVOLVE #204

Closed
Katetc opened this issue Sep 2, 2020 · 14 comments
Closed

Convert F-compsets to use stub glacier instead of CISM%NOEVOLVE #204

Katetc opened this issue Sep 2, 2020 · 14 comments
Assignees
Labels
answer changing answer changing tag enhancement New feature or request

Comments

@Katetc
Copy link
Collaborator

Katetc commented Sep 2, 2020

We had a meeting with @billsacks and @mvertens today to address issues with long test suite build times and calendars in compsets that use CISM%NOEVOLVE. We decided that the long term goal would be to build a NUOPC-based data glacier component that used active CISM output. But, this is likely several months to a year out. To address current issues, the LIWG is comfortable with other components moving to use stub glacier in their compsets temporarily.

I can update the F cases (and any other CAM-owned compsets that use CISM currently) to use stub glacier. This will not go into the 2.2 release. It will change all baseline answers slightly, very likely.

@cacraigucar
Copy link
Collaborator

Will replace CISM2%NOEVOLVE with SGLC

@Katetc
Copy link
Collaborator Author

Katetc commented Dec 8, 2021

I actually made these changes on a branch last week and ran the aux_cam tests. There were A LOT of answer changes. I'm not sure of the best way to validate this. I am going to check in with Bill Sacks.

@gold2718
Copy link
Collaborator

gold2718 commented Dec 8, 2021

We expect a lot of answer changes, the issue is whether they are significantly bigger than roundoff.
How big are these changes, especially in CAM?

@billsacks
Copy link
Member

Larger than roundoff answer changes are expected because glacier cover will be different over Greenland.

@cacraigucar
Copy link
Collaborator

cacraigucar commented Dec 8, 2021

This is starting to feel like a high priority issue for a number of reasons:

  1. Using the default intel compiler on izumi with DEBUG=T, the job errors out in glissade_velo_higher
  2. It takes a long time to run glissade (when I use totalview, it takes a significant amount of time to get through its initialization)
  3. I've been told that the compilation time is significant
  4. According to @adamrher who consulted with @mvertens, CISM2%NOEVOLVE is not supported in NUOPC

@Katetc - Since you've started this, would you be willing to take the lead on this with the goal being of creating a PR in the next week or two? Or would you like for me to take the lead on this?

If I do it, I'd probably treat it like any other answer component change and for the most part accept the answer changes as they are and have this be the only change in the CAM tag. I'd probably ask the scientists at the Tuesday AMP meeting if they want any special tests run prior to committing this change.

@Katetc
Copy link
Collaborator Author

Katetc commented Dec 8, 2021

@cacraigucar I was looking into the answer changes today and I discovered that I was testing against the wrong baseline. I'll rerun the tests today and I think I can have a PR made tomorrow. The issue of how Stub glacier affects an F compost is much bigger than just the few lines of changes needed to implement. We can discuss validation on the PR.

@mvertens
Copy link

mvertens commented Dec 8, 2021 via email

@mvertens
Copy link

mvertens commented Dec 8, 2021 via email

@gold2718
Copy link
Collaborator

gold2718 commented Dec 8, 2021

CISM2%NOEVOLVE is supported in NUOPC. It just adds complications when run in an F compset.

Even if it is supported, I think we should use stub for now. Perhaps when a data glacier component is available we can try that.

@mvertens
Copy link

mvertens commented Dec 8, 2021 via email

@billsacks
Copy link
Member

Regarding the changes from running with SGLC instead of CISM: see https://escomp.github.io/cism-docs/cism-in-cesm/versions/master/html/clm-cism-coupling.html#stub-glc-model-cism-absent

@adamrher
Copy link

adamrher commented Dec 9, 2021

@billsacks If I'm understanding the SGLC functionality correctly, CLM units with glacier ECs will use the subgrid glacier area fractions from the surfdat file. That is fine by me. But I would prefer that at least the workhorse grids of CESM (e.g., f19_f19_mg17, f09_f09_mg17, ne30pg3_ne30pg3_mg17) use surfdat files using the new CTSM glacier dataset that Rene and I developed (ESCOMP/CTSM#1406). In that dataset, the EC's are derived from the BedMachine datasets that CISM is (or should be using @whlipscomb?) using as its initial conditions for NO_EVOLVE configurations. This would result in little difference between SGLC and NO_EVOLVE, I think.

I suspect that new surfdats have not yet been made with the new glacier dataset?

@whlipscomb
Copy link

@adamrher, I agree. There's nothing CISM-specific about using BedMachine data to overwrite GMTED over Greenland and Antarctica. It's just the best dataset for these regions, so we might as well use it consistently across components.

As you say, this would have the side benefit of removing diffs between NO_EVOLVE and SGLC, though I'm not sure whether or not answers would be BFB.

@billsacks
Copy link
Member

Updating CTSM's surface datasets to use the new glacier dataset is on the list for CTSM5.2, where @ekluzek will be doing a massive update of a bunch of surface dataset fields to newer versions.

Katetc added a commit that referenced this issue Dec 18, 2021
cam6_3_038: Change CISM%NOEVOLVE to SGLC. Changes compsets that use CISM%NOEVOLVE to use SGLC in the F-compsets managed by CAM. Passes aux_cam test suite on Cheyenne but has baseline changes for all compsets changed. Also includes a new CIME tag for Izumi network changes. Fixes #204
@gold2718 gold2718 moved this to Done in CAM Development Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answer changing answer changing tag enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

8 participants