-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_015: Miscellaneous fixes #1072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-eaton
added
BFB
bit for bit tag
bug-fix
This PR was created to fix a specific bug.
labels
Jul 3, 2024
cacraigucar
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that Courtney approved the cam_history.F90 changes in #1043
cacraigucar
changed the title
cam6_4_015?: Miscellaneous fixes
cam6_4_015: Miscellaneous fixes
Jul 22, 2024
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Oct 16, 2024
Merge pull request ESCOMP#1072 from brian-eaton/misc02 cam6_4_015: Miscellaneous fixes ESCOMP commit: fe60b8d
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Oct 16, 2024
Merge pull request ESCOMP#1072 from brian-eaton/misc02 cam6_4_015: Miscellaneous fixes ESCOMP commit: fe60b8d
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Nov 8, 2024
Merge pull request ESCOMP#1072 from brian-eaton/misc02 cam6_4_015: Miscellaneous fixes ESCOMP commit: fe60b8d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses these issues:
. Issue #1045 - buildcpp does not report errors reported by cam configure
the log output
. Issue #1015 - SILHS subcolumns output as all zeros.
the SE dycore. A fix is added to check_energy.F90. This doesn't fix
the problem with zeros in the subcolumn output, but that is the same
problem previously reported for COSP in issue COSP output appears to be broken #944. The problem only
appears when SE grid output is interpolated. A workaround is to output
the subcolumns on the native SE grid.
. Issue #1044 - Remove solar_htng_spctrl_scl from aquaplanet use case
settings of several variables. The second setting is not used because
the first setting takes precedence. Note that the setting of
solar_htng_spctrl_scl to false in aquaplanet_rce_cam6.xml is needed
because it is overriding the default of true for cam6 with RRTMG.
. resolves #1045 (and closes #1046)
. resolves #1015
. resolves #1044