Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_015: Miscellaneous fixes #1072

Merged
merged 13 commits into from
Jul 23, 2024
Merged

Conversation

brian-eaton
Copy link
Collaborator

@brian-eaton brian-eaton commented Jul 3, 2024

Addresses these issues:

. Issue #1045 - buildcpp does not report errors reported by cam configure

  • modify buildcpp so that error messages from CAM's configure appear in
    the log output

. Issue #1015 - SILHS subcolumns output as all zeros.

  • testing for this issue revealed a bug when subcolumns were used with
    the SE dycore. A fix is added to check_energy.F90. This doesn't fix
    the problem with zeros in the subcolumn output, but that is the same
    problem previously reported for COSP in issue COSP output appears to be broken #944. The problem only
    appears when SE grid output is interpolated. A workaround is to output
    the subcolumns on the native SE grid.

. Issue #1044 - Remove solar_htng_spctrl_scl from aquaplanet use case

  • also cleaned up the aquaplanet_rce_cam6.xml file which had duplicated
    settings of several variables. The second setting is not used because
    the first setting takes precedence. Note that the setting of
    solar_htng_spctrl_scl to false in aquaplanet_rce_cam6.xml is needed
    because it is overriding the default of true for cam6 with RRTMG.

. resolves #1045 (and closes #1046)
. resolves #1015
. resolves #1044

@brian-eaton brian-eaton added BFB bit for bit tag bug-fix This PR was created to fix a specific bug. labels Jul 3, 2024
@brian-eaton brian-eaton self-assigned this Jul 3, 2024
@brian-eaton brian-eaton marked this pull request as ready for review July 15, 2024 22:13
@cacraigucar cacraigucar self-requested a review July 19, 2024 18:43
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that Courtney approved the cam_history.F90 changes in #1043

@cacraigucar cacraigucar changed the title Miscellaneous fixes cam6_4_015?: Miscellaneous fixes Jul 19, 2024
@cacraigucar cacraigucar changed the title cam6_4_015?: Miscellaneous fixes cam6_4_015: Miscellaneous fixes Jul 22, 2024
@brian-eaton brian-eaton merged commit fe60b8d into ESCOMP:cam_development Jul 23, 2024
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1072 from brian-eaton/misc02

cam6_4_015: Miscellaneous fixes

ESCOMP commit: fe60b8d
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1072 from brian-eaton/misc02

cam6_4_015: Miscellaneous fixes

ESCOMP commit: fe60b8d
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Nov 8, 2024
Merge pull request ESCOMP#1072 from brian-eaton/misc02

cam6_4_015: Miscellaneous fixes

ESCOMP commit: fe60b8d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BFB bit for bit tag bug-fix This PR was created to fix a specific bug.
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants