Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam6_4_012: climate chemistry compset #1074

Merged
merged 15 commits into from
Jul 20, 2024
Merged

cam6_4_012: climate chemistry compset #1074

merged 15 commits into from
Jul 20, 2024

Conversation

fvitt
Copy link

@fvitt fvitt commented Jul 5, 2024

Add trop_strat_mam5_ts4 chemistry package and FCts4MTHIST compset.

Also fixes a problem in cam7 physics where the water paths are not defined before they are used in cloud optics on the 1st time step.

Closes #1064
Closes #1065

fvitt added 8 commits June 25, 2024 11:56
@fvitt
implement climate chemistry compset
4fd9554 
        modified:   bld/build-namelist
        modified:   bld/config_files/definition.xml
        modified:   bld/configure
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/chem_mech.doc
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/chem_mech.in
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/chem_mods.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/m_rxt_id.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/m_spc_id.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_adjrxt.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_exp_sol.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_imp_sol.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_indprd.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_lin_matrix.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_lu_factor.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_lu_solve.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_nln_matrix.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_phtadj.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_prod_loss.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_rxt_rates_conv.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_setrxt.F90
        new file:   src/chemistry/pp_trop_strat_mam5_ts4/mo_sim_dat.F90
@fvitt
add use case file
a1e2b83 
        new file:   bld/namelist_files/use_cases/hist_trop_strat_ts4_cam7.xml
@fvitt
updates to user rxtns for tagged co; set rxn_rate_sums
39e1a8a 
        modified:   bld/namelist_files/use_cases/hist_trop_strat_ts4_cam7.xml
        modified:   src/chemistry/mozart/mo_usrrxt.F90
@fvitt
low res IC and izumi test
fa5ea51 
        modified:   bld/namelist_files/namelist_defaults_cam.xml
        modified:   cime_config/testdefs/testlist_cam.xml
@fvitt
set flbc options in use case file, rxn_rate_sums in namelist_defaults
18d7e5c 
        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_defaults_cam.xml
        modified:   bld/namelist_files/use_cases/hist_trop_strat_ts4_cam7.xml
@fvitt
initial pbuf water path fields to zero for cloud optics
27e49fd 
        modified:   src/physics/cam/cloud_diagnostics.F90
        modified:   src/physics/cam/physpkg.F90
        modified:   src/physics/cam_dev/physpkg.F90
@fvitt
merge to head of cam_development
89166a4
@fvitt
update test list
b172920 
	modified:   cime_config/testdefs/testlist_cam.xml
@fvitt fvitt added the BFB bit for bit tag label Jul 5, 2024
@fvitt fvitt requested a review from cacraigucar July 5, 2024 13:46
@fvitt fvitt self-assigned this Jul 5, 2024
@adamrher
Copy link

adamrher commented Jul 5, 2024

Thanks Francis for catching those uninitialized pbufs ICLWP / ICIWP in cam7. That was an oversight on my part.

@fvitt
initialize water paths to zero only on startup runs
494583a 
	modified:   src/physics/cam/cloud_diagnostics.F90
@adamrher adamrher mentioned this pull request Jul 10, 2024
Closed
fvitt added 2 commits July 10, 2024 08:22
@fvitt
include megan emissions settings
ca03c4a 
        modified:   bld/build-namelist
        modified:   bld/namelist_files/use_cases/hist_trop_strat_ts4_cam7.xml
@fvitt
include transient solar input file
8750181 
        modified:   bld/namelist_files/use_cases/hist_trop_strat_ts4_cam7.xml
@fvitt fvitt marked this pull request as ready for review July 10, 2024 23:02
@fvitt
Copy link
Author

fvitt commented Jul 10, 2024

@cacraigucar This ready for review now.

@cacraigucar cacraigucar changed the title climate chemistry compset cam6_4_012: climate chemistry compset Jul 19, 2024
@fvitt fvitt merged commit 662a6f0 into ESCOMP:cam_development Jul 20, 2024
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
@fvitt
ESCOMP tag: cam6_4_012
f0eea4d 
Merge pull request ESCOMP#1074 from fvitt/climchem

cam6_4_012: climate chemistry compset

ESCOMP commit: 662a6f0
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
@fvitt
ESCOMP tag: cam6_4_012
42a7846 
Merge pull request ESCOMP#1074 from fvitt/climchem

cam6_4_012: climate chemistry compset

ESCOMP commit: 662a6f0
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Nov 8, 2024
@fvitt
ESCOMP tag: cam6_4_012
7650946 
Merge pull request ESCOMP#1074 from fvitt/climchem

cam6_4_012: climate chemistry compset

ESCOMP commit: 662a6f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cacraigucar cacraigucar cacraigucar approved these changes

Assignees

@fvitt fvitt

Labels
BFB bit for bit tag
Projects
CAM Development
Status: Tag
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fvitt @adamrher @cacraigucar