Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_020: dz fix in convproc #1111

Merged
merged 8 commits into from
Aug 14, 2024
Merged

Conversation

fvitt
Copy link

@fvitt fvitt commented Jul 26, 2024

This fixes an error in the calculation of dz in the aerosol convective removal code.

Closes #1118
Closes #1030
Closes #1125
Closes #1126

        modified:   src/chemistry/modal_aero/modal_aero_convproc.F90
@fvitt fvitt added answer changing answer changing tag bug-fix This PR was created to fix a specific bug. labels Jul 26, 2024
@fvitt fvitt requested a review from cacraigucar July 26, 2024 20:48
@fvitt fvitt self-assigned this Jul 26, 2024
@fvitt
Copy link
Author

fvitt commented Jul 26, 2024

@tilmes is testing the fix

	modified:   bld/namelist_files/use_cases/waccm_sc_2000_cam6.xml
	modified:   bld/namelist_files/use_cases/waccm_sc_2010_cam6.xml
@cacraigucar cacraigucar marked this pull request as draft August 6, 2024 15:18
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good. If you want to combine with #1118, feel free to do so

@fvitt
Copy link
Author

fvitt commented Aug 6, 2024

@adamrher
Copy link

adamrher commented Aug 6, 2024

I really don't expect this bug fix to change answers that much, but @tilmes these diagnostics are too limited -- they don't have any radiative fluxes except global restom. Can we get them somehow?

@tilmes
Copy link
Collaborator

tilmes commented Aug 7, 2024

I am doing a low-top model run with all the output, so we can run more comprehensive diagnostics and will post it asap. The earlier diagnostics show zonal mean aerosol comparisons and it indeed shows a very small impact. More to come soon.

@tilmes
Copy link
Collaborator

tilmes commented Aug 8, 2024

Here are the new diagnostics with the low-top model:
https://acomstaff.acom.ucar.edu/tilmes/amwg/cam7/f.e23_beta02.FLTHIST_ne30.conv_dz_bug_1995_2004_vs_f.e23_beta02.FLTHIST_ne30.001_1995_2004/website/index.html

Very little change, a little bit in dust AOD, Simone

@fvitt fvitt marked this pull request as ready for review August 9, 2024 14:56
@fvitt
Copy link
Author

fvitt commented Aug 9, 2024

@cacraigucar
If there are no objections, this is ready to merge into cam_development.

@cacraigucar
Copy link
Collaborator

@PeterHjortLauritzen - As the AMWG rep, do you or @adamrher who has commented on this PR need to approve this change, or is @tilmes approval all that is required?

@PeterHjortLauritzen
Copy link
Collaborator

Not seeing anything of concern ... so unless @adamrher has any concerns I'd say "approve"

@adamrher
Copy link

adamrher commented Aug 9, 2024

I approve!

@cacraigucar cacraigucar changed the title dz fix in convproc cam6_4_020: dz fix in convproc Aug 9, 2024
@fvitt fvitt merged commit e23526f into ESCOMP:cam_development Aug 14, 2024
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1111 from fvitt/aeroconv_dz

cam6_4_020: dz fix in convproc

ESCOMP commit: e23526f
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1111 from fvitt/aeroconv_dz

cam6_4_020: dz fix in convproc

ESCOMP commit: e23526f
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Nov 8, 2024
Merge pull request ESCOMP#1111 from fvitt/aeroconv_dz

cam6_4_020: dz fix in convproc

ESCOMP commit: e23526f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
answer changing answer changing tag bug-fix This PR was created to fix a specific bug. chill CoupledEval3
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

5 participants