-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam6_4_020: dz fix in convproc #1111
Conversation
modified: src/chemistry/modal_aero/modal_aero_convproc.F90
@tilmes is testing the fix |
modified: bld/namelist_files/use_cases/waccm_sc_2000_cam6.xml modified: bld/namelist_files/use_cases/waccm_sc_2010_cam6.xml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It all looks good. If you want to combine with #1118, feel free to do so
I really don't expect this bug fix to change answers that much, but @tilmes these diagnostics are too limited -- they don't have any radiative fluxes except global restom. Can we get them somehow? |
I am doing a low-top model run with all the output, so we can run more comprehensive diagnostics and will post it asap. The earlier diagnostics show zonal mean aerosol comparisons and it indeed shows a very small impact. More to come soon. |
Here are the new diagnostics with the low-top model: Very little change, a little bit in dust AOD, Simone |
@cacraigucar |
@PeterHjortLauritzen - As the AMWG rep, do you or @adamrher who has commented on this PR need to approve this change, or is @tilmes approval all that is required? |
Not seeing anything of concern ... so unless @adamrher has any concerns I'd say "approve" |
I approve! |
Merge pull request ESCOMP#1111 from fvitt/aeroconv_dz cam6_4_020: dz fix in convproc ESCOMP commit: e23526f
Merge pull request ESCOMP#1111 from fvitt/aeroconv_dz cam6_4_020: dz fix in convproc ESCOMP commit: e23526f
Merge pull request ESCOMP#1111 from fvitt/aeroconv_dz cam6_4_020: dz fix in convproc ESCOMP commit: e23526f
This fixes an error in the calculation of dz in the aerosol convective removal code.
Closes #1118
Closes #1030
Closes #1125
Closes #1126