Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam6_4_031: fix issues #1108, #1106, #1058, #1051, #1050; merge PR#1101 #1131

Merged
merged 14 commits into from
Sep 9, 2024

Conversation

brian-eaton
Copy link
Collaborator

@brian-eaton brian-eaton commented Aug 20, 2024

Issue #1108 - More robust logic in gw_drag.F90 when deep_scheme='off'

  • Modify build-namelist to set use_gw_convect_dp=.false. when
    deep_scheme='off'. In gw_drag::gw_tend check whether field TTEND_DP is
    in the pbuf. If so then associate the ttend_dp pointer. If not then
    allocate the ttend_dp pointer and set to zero.

PR #1101 - improved fix for rh write performance

  • reorder output fields. Merge Jim's PR into this one.

Issue #1106 - Report an error if a user uses --model_top with anything other than cam7

  • configure reports this error, but the output in the log file gets
    obscured by a stack traceback issued from buildnml which is not useful.
    The fix implemented in buildnml replaces the "raise RuntimeError" call by
    a warning message in the log file. If a subsequent check for CAM's
    config_cache.xml file fails, then execution is terminated by a call to
    the CIME.utils "expect()" routine.

Issue #1058 - Remove unused pbuf variable smaw

  • Remove both smaw and turbtype from physics buffer. Neither is used.
    Remove the calculation of smaw entirely. Calculation of turbtype
    remains. It is used locally, and may be written to history file
    (UW_turbtype).

Issue #1051 - Bad logic in SE dycore "interpolate_vector" subroutines

  • These subroutines are not currently used by CAM as they are restricted to
    interpolating fields on the GLL grid. Fix the conditional logic and
    update the endrun message.

Issue #1050 - Remove CAM3 as a compset or configure option

fix #1108
resolve #1101
fix #1106
fix #1058
fix #1051
fix #1050

@brian-eaton brian-eaton added enhancement New feature or request bug-fix This PR was created to fix a specific bug. labels Aug 20, 2024
@brian-eaton brian-eaton self-assigned this Aug 20, 2024
@brian-eaton brian-eaton changed the title fix issue #1108, merge PR#1101 fix issues #1108, #1106; merge PR#1101 Aug 21, 2024
@brian-eaton brian-eaton changed the title fix issues #1108, #1106; merge PR#1101 fix issues #1108, #1106, #1058; merge PR#1101 Aug 22, 2024
@brian-eaton brian-eaton changed the title fix issues #1108, #1106, #1058; merge PR#1101 fix issues #1108, #1106, #1058, #1051, #1050; merge PR#1101 Aug 28, 2024
@cacraigucar cacraigucar changed the title fix issues #1108, #1106, #1058, #1051, #1050; merge PR#1101 cam6_4_031: fix issues #1108, #1106, #1058, #1051, #1050; merge PR#1101 Sep 6, 2024
@nusbaume nusbaume merged commit 9f0cb73 into ESCOMP:cam_development Sep 9, 2024
2 checks passed
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1131 from brian-eaton/misc05

cam6_4_031: fix issues ESCOMP#1108, ESCOMP#1106, ESCOMP#1058, ESCOMP#1051, ESCOMP#1050; merge PR#1101

ESCOMP commit: 9f0cb73
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Oct 16, 2024
Merge pull request ESCOMP#1131 from brian-eaton/misc05

cam6_4_031: fix issues ESCOMP#1108, ESCOMP#1106, ESCOMP#1058, ESCOMP#1051, ESCOMP#1050; merge PR#1101

ESCOMP commit: 9f0cb73
gold2718 pushed a commit to gold2718/CAM that referenced this pull request Nov 8, 2024
Merge pull request ESCOMP#1131 from brian-eaton/misc05

cam6_4_031: fix issues ESCOMP#1108, ESCOMP#1106, ESCOMP#1058, ESCOMP#1051, ESCOMP#1050; merge PR#1101

ESCOMP commit: 9f0cb73
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This PR was created to fix a specific bug. enhancement New feature or request
Projects
Status: Tag
Development

Successfully merging this pull request may close these issues.

3 participants