Timestamp in rpointer name #1147
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brian-eaton
requested changes
Oct 3, 2024
src/control/cam_initfiles.F90
Outdated
Comment on lines
122
to
125
| write(iulog, "Warning : rpointer file "//trim(rest_pfile)//" not found.") | ||
| rest_pfile = "rpointer.cam"//trim(inst_suffix) | ||
| inquire(file=trim(rest_pfile),exist=found) |
There was a problem hiding this comment.
Suggested change
| write(iulog, "Warning : rpointer file "//trim(rest_pfile)//" not found.") | |
| rest_pfile = "rpointer.cam"//trim(inst_suffix) | |
| inquire(file=trim(rest_pfile),exist=found) | |
| write(iulog, "INFO : rpointer file "//trim(rest_pfile)//" not found.") | |
| rest_pfile = "rpointer.cam"//trim(inst_suffix) | |
| write(iulog, " Try looking for "//trim(rest_pfile)//" ...") | |
| inquire(file=trim(rest_pfile),exist=found) |
src/control/runtime_opts.F90
Outdated
| @@ -109,7 +109,6 @@ subroutine read_namelist(nlfilename, single_column, scmlat, scmlon) | |||
| logical, intent(in) :: single_column | |||
| real(r8), intent(in) :: scmlat | |||
| real(r8), intent(in) :: scmlon | |||
|
|
|||
There was a problem hiding this comment.
Only a whitespace change. This file should be reverted to original.
Comment on lines
+1979
to
+1980
| restart_pfile = interpret_filename_spec('rpointer.cpl.%y-%m-%d-%s',& | ||
| yr_spec=yr_spec, mon_spec=mon_spec, day_spec=day_spec, sec_spec= sec_spec ) |
There was a problem hiding this comment.
restart_pfile is set but not used. Is this for a future need when the coupler external is updated?
There was a problem hiding this comment.
Thanks for pointing out this bug, it should replace 'rpointer.cpl' below
jedwards4b
force-pushed
the
timestamp_in_rpointer_name
branch
from
4ed77db
to
0007c77
Compare
|
I'm not sure what happened to the history here. I rebased to cam_development tag: cam6_4_043 and pushed back. Now this PR shows my changes applied twice, but git log in my sandbox does not show the original commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a timestamp in the rpointer name.
This is a backward compatible change in that rpointer.cam will still work
but new files will include a timestamp.
Fixes #1146