-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New CARMA trop_strat aerosol model #1210
base: cam_development
Are you sure you want to change the base?
Conversation
…stly r8 and cleanup modified: src/physics/carma/cam/carma_precision_mod.F90 modified: src/physics/carma/models/bc_strat/carma_model_mod.F90 modified: src/physics/carma/models/cirrus/carma_model_mod.F90 modified: src/physics/carma/models/cirrus/growevapl.F90 modified: src/physics/carma/models/cirrus_dust/carma_mod.F90 modified: src/physics/carma/models/cirrus_dust/carma_model_mod.F90 modified: src/physics/carma/models/cirrus_dust/growevapl.F90 modified: src/physics/carma/models/dust/carma_model_mod.F90 modified: src/physics/carma/models/meteor_impact/carma_model_flags_mod.F90 modified: src/physics/carma/models/meteor_impact/carma_model_mod.F90 modified: src/physics/carma/models/meteor_smoke/carma_model_mod.F90 modified: src/physics/carma/models/mixed_sulfate/carma_model_mod.F90 modified: src/physics/carma/models/pmc/carma_model_mod.F90 modified: src/physics/carma/models/pmc_sulfate/carma_model_mod.F90 modified: src/physics/carma/models/sea_salt/carma_model_mod.F90 modified: src/physics/carma/models/sulfate/carma_model_mod.F90 modified: src/physics/carma/models/test_detrain/carma_model_mod.F90 modified: src/physics/carma/models/test_growth/carma_model_mod.F90 modified: src/physics/carma/models/test_passive/carma_model_mod.F90 modified: src/physics/carma/models/test_radiative/carma_model_mod.F90 modified: src/physics/carma/models/test_swelling/carma_model_mod.F90 modified: src/physics/carma/models/test_tracers/carma_model_mod.F90 modified: src/physics/carma/models/test_tracers2/carma_model_mod.F90 modified: src/physics/carma/models/tholin/carma_model_mod.F90 modified: test/system/TR8.sh
modified: cime_config/testdefs/testlist_cam.xml
modified: src/physics/cam/ndrop.F90 modified: src/physics/cam/nucleate_ice.F90 modified: src/physics/cam/physics_types.F90
modified: src/chemistry/aerosol/carma_aerosol_properties_mod.F90 modified: src/chemistry/carma_aero/carma_aero_gasaerexch.F90 modified: src/physics/carma/cam/carma_intr.F90 modified: src/physics/carma/models/trop_strat_soa1/carma_model_mod.F90 modified: src/physics/carma/models/trop_strat_soa5/carma_model_mod.F90
…settings modified: bld/build-namelist modified: src/physics/cam/nucleate_ice_cam.F90
modified: src/chemistry/aerosol/mo_setsox.F90 modified: src/chemistry/bulk_aero/aero_model.F90 modified: src/chemistry/bulk_aero/sox_cldaero_mod.F90 modified: src/chemistry/carma_aero/aero_model.F90 modified: src/chemistry/carma_aero/sox_cldaero_mod.F90 modified: src/chemistry/modal_aero/aero_model.F90 modified: src/chemistry/modal_aero/sox_cldaero_mod.F90 modified: src/physics/spcam/ecpp/ecpp_modal_cloudchem.F90 modified: src/physics/spcam/ecpp/module_ecpp_ppdriver2.F90 modified: src/physics/spcam/ecpp/module_ecpp_td2clm.F90
modified: src/chemistry/geoschem/chemistry.F90
modified: bld/build-namelist modified: bld/namelist_files/namelist_defaults_cam.xml modified: src/physics/cam/nucleate_ice.F90
Draft PR for now. Needs to follow PR #1201. |
modified: src/chemistry/mozart/mo_usrrxt.F90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still have quite a ways to go, but I am submitting my current review comments so they don't get lost.
@@ -4996,7 +5071,7 @@ sub check_input_files { | |||
} | |||
# Look for values that begin with 'X:name:name2' where X is one of [AMN] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment needs updating to add `B1
<ncdata dyn="fv" hgrid="10x15" nlev="32" carma="trop_strat_soa5">atm/cam/inic/fv/carma_trop_strat_2000_10x15_spinup01.cam.i.0002-01-01-00000_c211027.nc</ncdata> | ||
<ncdata dyn="fv" hgrid="10x15" nlev="32" aquaplanet="1" carma="trop_strat_soa5">atm/cam/inic/fv/aqua_carma_trop_strat_10x15_spinup01.cam.i.0002-01-01-00000_c211027.nc</ncdata> | ||
|
||
<ncdata dyn="fv" hgrid="1.9x2.5" nlev="32" aquaplanet="1" carma="trop_strat_soa5">atm/cam/inic/fv/QPCARMATS_f19_carmats4038_spinup01_0002-01-01_c241029.nc</ncdata> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be imported into the svn repository
<ncdata dyn="fv" hgrid="1.9x2.5" nlev="32" aquaplanet="1" carma="trop_strat_soa5">atm/cam/inic/fv/QPCARMATS_f19_carmats4038_spinup01_0002-01-01_c241029.nc</ncdata> | ||
|
||
<ncdata dyn="fv" hgrid="10x15" nlev="70" aquaplanet="1" carma="trop_strat_soa1">atm/waccm/ic/aqua_carma_waccm_0002-01-01_10x15_L70_c220325.nc</ncdata> | ||
<ncdata dyn="fv" hgrid="1.9x2.5" nlev="70" carma="trop_strat_soa1">atm/waccm/ic/FWmaCARMAHIST_f19_carmats038_spinupl03.cam.i.1980-01-01_c241025.nc</ncdata> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be added to the svn repository
|
||
<ncdata dyn="fv" hgrid="10x15" nlev="70" aquaplanet="1" carma="trop_strat_soa1">atm/waccm/ic/aqua_carma_waccm_0002-01-01_10x15_L70_c220325.nc</ncdata> | ||
<ncdata dyn="fv" hgrid="1.9x2.5" nlev="70" carma="trop_strat_soa1">atm/waccm/ic/FWmaCARMAHIST_f19_carmats038_spinupl03.cam.i.1980-01-01_c241025.nc</ncdata> | ||
<ncdata dyn="fv" hgrid="1.9x2.5" nlev="70" aquaplanet="1" carma="trop_strat_soa1">atm/cam/inic/fv/aqua_carma_waccm_0002-01-01_1.9x2.5_L70_c220809.nc</ncdata> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file needs to be added to the svn repository
<BC_GAINS_filename >atm/cam/chem/carma/data/ETP_base_CLE_V5_BC_2010.nc</BC_GAINS_filename> | ||
<OC_GAINS_filename >atm/cam/chem/carma/data/ETP_base_CLE_V5_OC_2010.nc</OC_GAINS_filename> | ||
<BC_ship_filename >atm/cam/chem/carma/data/IPCC_BC_ships_2010_0.5x0.5.nc</BC_ship_filename> | ||
<OC_ship_filename >atm/cam/chem/carma/data/IPCC_OC_ships_2010_0.5x0.5.nc</OC_ship_filename> | ||
<BC_GFEDv3_filename>atm/cam/chem/carma/data/GFEDv3_BC_2010.nc</BC_GFEDv3_filename> | ||
<OC_GFEDv3_filename>atm/cam/chem/carma/data/GFEDv3_OC_2010.nc</OC_GFEDv3_filename> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not finding the atm/cam/chem/carma/data directory being in the svn repository. I believe all of these files need to be added to it.
Since I'm uncovering a good number of files that need to be added to the svn repo, I will leave the checking of the rest of the files up to the developer to find them all.
<entry id="carma_diags_file" type="integer" category="carma" | ||
group="carma_nl" valid_values="" > | ||
When > 0, indicates the history file to be used by default for | ||
diagnostic output. A value of 1 indicated the h0 file. | ||
Default: 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description does not indicate what a value of 0
does.
Introduce CARMA trop_strat sectional aerosol model which can be as an alternative to the modal aerosol aerosol representation in CAM physics.
closes #495