cam6_4_066: Negative wet dep messages #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modified: src/chemistry/aerosol/wetdep.F90
modified: src/chemistry/aerosol/wetdep.F90
cacraigucar
changed the title
cacraigucar
requested changes
Feb 12, 2025
| found = .false. | ||
| do i = 1,ncol | ||
| if ( dblchek(i) < 0._r8 ) then | ||
| if (dblchek(i) < -1.e-10_r8) then |
There was a problem hiding this comment.
Perhaps a comment on why -1.3-10_r8 is being used instead of a normal check of <0 would be appropriate
| @@ -645,22 +645,20 @@ subroutine wetdepa_v2( & | |||
|
|
|||
| end do ! End of i = 1, ncol | |||
|
|
|||
| #ifdef DEBUG | |||
There was a problem hiding this comment.
Why is this checking only being done for #DEBUG?
There was a problem hiding this comment.
The check are catching a lot of insignificant small negative values which have been to cesm log an mostly ignored.
With the addition of the endrun call, we are only doing the checks in debug mode.
There was a problem hiding this comment.
Perhaps a comment about this would be appropriate?
cacraigucar
approved these changes
Feb 13, 2025
gold2718
pushed a commit
to gold2718/CAM
that referenced
this pull request
Feb 19, 2025
Merge pull request ESCOMP#1228 from fvitt/negwetdep cam6_4_066: Negative wet dep messages ESCOMP commit: 1ba445b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This limits the negative aerosol wet deposition messages written to cesm.log
Addresses #1132