Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cam_cesm2_1_rel_52: Fix COSP snow optics bug, and nhtfrq namelist definition. #279

Merged
merged 5 commits into from
Nov 24, 2020
Merged

cam_cesm2_1_rel_52: Fix COSP snow optics bug, and nhtfrq namelist definition. #279

merged 5 commits into from
Nov 24, 2020

Conversation

nusbaume
Copy link
Collaborator

Fixes #262
Fixes #265

This PR also changes answers for COSP, so I am having two scientists double-check the code change.

@nusbaume nusbaume added documentation Improvements or additions to documentation bug-fix This PR was created to fix a specific bug. labels Nov 18, 2020
@nusbaume nusbaume self-assigned this Nov 18, 2020
@nusbaume
Copy link
Collaborator Author

@zyuying and @brianpm this pull request changes answers for the COSP outputs. Can you please verify that this is expected, and also make sure that my code changes to cosp_optics.F90 are correct? Thank you!

@nusbaume nusbaume mentioned this pull request Nov 18, 2020
Open
@brianpm
Copy link
Collaborator

brianpm commented Nov 18, 2020

For sure the COSP output should change. It should only impact the CALIPSO / lidar simulator output, I think.

@zyuying
Copy link

zyuying commented Nov 18, 2020

@nusbaume , Your code changes are correct. As @brianpm mentioned, it will only change the lidar simulator output.

@nusbaume
Copy link
Collaborator Author

Thanks! I verified that only the CALIPSO outputs change, so I believe this PR is ready for review from the SEs.

@cacraigucar cacraigucar changed the title Fix COSP snow optics bug, and nhtfrq namelist definition. cam_cesm2_1_rel_52: Fix COSP snow optics bug, and nhtfrq namelist definition. Nov 19, 2020
@nusbaume nusbaume merged commit 00589cc into ESCOMP:cam_cesm2_1_rel Nov 24, 2020
@nusbaume nusbaume deleted the cosp_bugfix_v2.1 branch November 24, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gold2718 gold2718 gold2718 approved these changes

@brian-eaton brian-eaton brian-eaton approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

Assignees

@nusbaume nusbaume

Labels
bug-fix This PR was created to fix a specific bug. documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nusbaume @brianpm @zyuying @gold2718 @brian-eaton @cacraigucar