Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cam_cesm2_1_rel_54: adding smyle branch #354

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

nanr
Copy link
Collaborator

@nanr nanr commented Apr 6, 2021

Adding the smyle compset for the SMYLE project. Fixes #256

@gold2718
Copy link
Collaborator

gold2718 commented Apr 6, 2021

@nanr, is it okay if this PR goes in without a regression test to protect the functionality? Is there a quick test that could be run?

@cacraigucar
Copy link
Collaborator

@nanr If you add me as a collaborator with write access on your fork of CAM in github, I can write up a ChangeLog and merge it directly from your fork. I can give you instructions on how to do this if you need that.

@gold2718
Copy link
Collaborator

gold2718 commented Apr 6, 2021

@nanr, I want to triple check that you want this to go only into CESM2.1 (i.e., not CESM2.2 or current development).

@nanr
Copy link
Collaborator Author

nanr commented Apr 6, 2021

@cacraigucar I think I should add you as a collaborator to my fork, if you tell me how to do that.

@nanr
Copy link
Collaborator Author

nanr commented Apr 6, 2021

@gold2718 thanks for checking. I THINK the smyle branch should not be limited to cesm2.1. I think that it should be carried through to CESM2.2 / current development, and if so, let me know how to proceed.

@gold2718
Copy link
Collaborator

gold2718 commented Apr 6, 2021

@nanr,
We will get it on CESM2.1 very soon. My understanding is that is the starting point for the SMYLE experiments -- is that correct?
We can then schedule it for the other branches. What is the use case for CESM2.2 -- is that part of the experiment plan?
For the CAM development branch, we will probably want a regression test (maybe even prebeta) to make sure nothing gets broken.

@cacraigucar
Copy link
Collaborator

@nanr On your github.com/nanr/CAM main page, go to settings. On the left, you'll see "manage access" . Click on that and then you should see "add collaborator". If you give me write access, that will be good.

@cacraigucar
Copy link
Collaborator

@nanr Please let me know if you'd like to make any changes to the ChangeLog. Or you can git pull , make your own edits and thengit commit and git push your changes back.

@cacraigucar
Copy link
Collaborator

@nanr Please let me know if you are okay with the ChangeLog. If you have no changes, I can go ahead and merge this into the cesm2_1 branch.

@cacraigucar cacraigucar changed the title adding smyle branch cam_cesm2_1_rel_54: adding smyle branch Apr 6, 2021
@nanr
Copy link
Collaborator Author

nanr commented Apr 6, 2021

@cacraigucar ChangeLog looks good. I have no changes. Thanks Cheryl.

@cacraigucar cacraigucar merged commit 571fd27 into ESCOMP:cam_cesm2_1_rel Apr 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants