-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cam_cesm2_1_rel_54: adding smyle branch #354
cam_cesm2_1_rel_54: adding smyle branch #354
Conversation
@nanr, is it okay if this PR goes in without a regression test to protect the functionality? Is there a quick test that could be run? |
@nanr If you add me as a collaborator with write access on your fork of CAM in github, I can write up a ChangeLog and merge it directly from your fork. I can give you instructions on how to do this if you need that. |
@nanr, I want to triple check that you want this to go only into CESM2.1 (i.e., not CESM2.2 or current development). |
@cacraigucar I think I should add you as a collaborator to my fork, if you tell me how to do that. |
@gold2718 thanks for checking. I THINK the smyle branch should not be limited to cesm2.1. I think that it should be carried through to CESM2.2 / current development, and if so, let me know how to proceed. |
@nanr, |
@nanr On your github.com/nanr/CAM main page, go to settings. On the left, you'll see "manage access" . Click on that and then you should see "add collaborator". If you give me write access, that will be good. |
@nanr Please let me know if you'd like to make any changes to the ChangeLog. Or you can |
@nanr Please let me know if you are okay with the ChangeLog. If you have no changes, I can go ahead and merge this into the cesm2_1 branch. |
@cacraigucar ChangeLog looks good. I have no changes. Thanks Cheryl. |
Adding the smyle compset for the SMYLE project. Fixes #256