cam6_3_035: CAM large misc tag

[cacraigucar]

Addresses numerous minor issues:

Closes #454
Closes #351
Closes #126
Closes #360
Closes #365
Closes #214
Closes #358
Closes #375
Closes #421
Closes #437
Closes #262
Closes #471

Includes "Adding zmconv_tau to CAM namelist options" (no issue opened)

#351 changes answers for CAM6 runs and #262 changes answers for COSP.

Making runs without #351 to verify that no other issues change answers

[MiCurry]

Looks great on the CLUBB output fix. There is another similar all-task write statement. Is it possible this PR can be used to wrap that print statement as well? (or remove it?). The line is here:

CAM/src/cpl/nuopc/atm_comp_nuopc.F90

Line 416 in b1d22e5

print *,__FILE__,__LINE__,nthrds

Its output looks like (1 for each task):

5984: atm_comp_nuopc.F90 416 1

[jedwards4b]

That's a debug statement that can be removed.

…

On Fri, Nov 19, 2021 at 12:22 PM Miles Curry ***@***.***> wrote: Looks great on the CLUBB output fix. There is another similar all-task write statement. Is it possible this PR can be used to wrap that print statement as well? (or remove it?). The line is here: https://github.com/ESCOMP/CAM/blob/b1d22e5cd63b1e66911598a666fb630028146f22/src/cpl/nuopc/atm_comp_nuopc.F90#L416 Its output looks like (1 for each task): 5984: atm_comp_nuopc.F90 416 1 — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#469 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABOXUGB45WEO3BJA3MJ77I3UM2PYNANCNFSM5IMUUXVQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

-- Jim Edwards CESM Software Engineer National Center for Atmospheric Research Boulder, CO

[MiCurry]

@cacraigucar thank you!

[adamrher]

CLUBB stuff looks good to me! I only suggested a change to the description of tau in namelist_definition

[gold2718]

Minor changes and questions.

[fvitt]

Seems okay to me

[nusbaume]

Looks good, thanks!

[gold2718]

My concerns have been addressed.
I think the others have been addressed, @adamrher, @Katetc, please resolve the issues you raised if you are satisfied with the changes.

[cacraigucar]

@Katetc - I am repeatedly getting an error in micro_mg_data: mgfieldpostproc_accumulate. Perhaps this is the reason that you didn't include the zm_conv_tau before? I'm not sure this is the culprit, but I'll be backing out a couple of changes to see which might be the one causing the issue.

[cacraigucar]

@Katetc - My tests last week were just extremely unlucky in hitting izumi errors repeatedly. After careful investigation, I concluded that it was just a computer hiccup. I was successfully able to run all the regression tests over the weekend though with three sets of NAG regression runs, each had a failing test, though the test which failed was different.

[Katetc]

@Katetc - My tests last week were just extremely unlucky in hitting izumi errors repeatedly. After careful investigation, I concluded that it was just a computer hiccup. I was successfully able to run all the regression tests over the weekend though with three sets of NAG regression runs, each had a failing test, though the test which failed was different.

Oh good. This makes A LOT more sense than having a new zm namelist variable cause mg errors!