Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

part of cam6_3_108: Cloud to ground lightning flash frequency passed to land model #747

Merged
merged 20 commits into from
Apr 27, 2023
Merged

part of cam6_3_108: Cloud to ground lightning flash frequency passed to land model #747

merged 20 commits into from
Apr 27, 2023

Conversation

fvitt
Copy link

@fvitt fvitt commented Feb 3, 2023

Closes #567

fvitt added 8 commits February 1, 2023 11:42
@fvitt
pass lightning flash frequency to mediator for CTSM
b66dd91 
        modified:   Externals.cfg
        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_definition.xml
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
        modified:   src/physics/cam/physpkg.F90
@fvitt
Improve cld-to-grnd lightning documentation; change "atm_lightning_fl…
6a89a31 
…ash_freq" to "atm_provides_lightning"; minor cleanup

        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_definition.xml
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
@fvitt
Fix restart issue -- use pbuf field for flash freq field
fde2a59 
        modified:   src/chemistry/mozart/chemistry.F90
        modified:   src/chemistry/mozart/mo_chemini.F90
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/physics/cam/physpkg.F90
@fvitt
Check namelist setting of atm_provides_lightning
9f0650e 
        modified:   bld/build-namelist
        modified:   src/cpl/nuopc/atm_import_export.F90
@fvitt
calc lightning only when cam phys is used
8566caa 
        modified:   bld/build-namelist
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
apply namelist scaling factor to flash freq
4afeaae 
        modified:   bld/build-namelist
        modified:   bld/namelist_files/namelist_definition.xml
        modified:   src/chemistry/mozart/chemistry.F90
        modified:   src/chemistry/mozart/mo_chemini.F90
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/control/runtime_opts.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
@fvitt
code clean up
1481f61 
        modified:   src/chemistry/mozart/chemistry.F90
        modified:   src/chemistry/mozart/mo_chemini.F90
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/chemistry/pp_none/chemistry.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/physics/cam/physpkg.F90
@fvitt
corrections for later cmeps
047793b 
        modified:   src/chemistry/mozart/mo_lightning.F90
        modified:   src/control/camsrfexch.F90
        modified:   src/cpl/nuopc/atm_import_export.F90
        modified:   src/physics/cam_dev/physpkg.F90
@fvitt fvitt added the BFB bit for bit tag label Feb 3, 2023
@fvitt fvitt added this to the CESM3 milestone Feb 3, 2023
@fvitt fvitt requested a review from lkemmons February 3, 2023 15:45
@fvitt fvitt self-assigned this Feb 3, 2023
fvitt
fvitt commented Feb 3, 2023
View reviewed changes
src/chemistry/mozart/mo_lightning.F90 Outdated

cld2grnd_flash_freq(i) = cam_in(c)%landfrac(i)*flash_freq_land *cgic(i,c) * factor ! cld-to-grnd flash frq (per min)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkemmons Does this formulation look correct for the cloud-to-ground lightning flash frequency? Is it correct to include factor here which is 0.1_r8*lght_no_prd_factor, the namelist lightning NOx production rate tuning parameter.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, 'factor' is just for getting the right amount of NO emissions per flash, and should not be applied to the flash frequency that is passed to the land.

@fvitt
atm_provides_lightning is FALSE if simple phys or aquaplanet
db9bb12 
	modified:   bld/build-namelist
	modified:   src/control/camsrfexch.F90
@fvitt
remove factor from cld2grnd flash freq; fix typos
39d1c7d 
        modified:   src/chemistry/mozart/mo_lightning.F90
fvitt
fvitt commented Feb 7, 2023
View reviewed changes
src/chemistry/mozart/mo_lightning.F90 Outdated

call addfld( 'LNO_COL_PROD', horiz_only, 'I', 'TG N/YR', 'lightning column NO source' )
call addfld( 'LNO_PROD', (/ 'lev' /), 'I', '/cm3/s', 'lightning insitu NO source' )
call addfld( 'FLASHENGY', horiz_only, 'I', 'J', 'lightning flash energy' ) ! flash energy
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lkemmons What should the units be on the flash energy?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The flash energy is in joules (J).
Could we change LNO_PROD units to 'molecules/cm3/s' - I think that is consistent with other chemical rates?

@fvitt
Minor changes to history fld units
723f1cd 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt fvitt marked this pull request as ready for review February 15, 2023 16:07
@wwieder wwieder mentioned this pull request Feb 16, 2023
Open
13 tasks
@wwieder
Copy link

wwieder commented Feb 17, 2023

This PR caught the attention of the LMWG. Thanks for working on this, @fvitt!

We're wondering what the timeline for this PR may be, as there's quite a bit of work this could spark on the land side if we can get interactive lightning (and therefore fire ignitions) into CESM3?

cacraigucar
cacraigucar requested changes Feb 27, 2023
View reviewed changes
Copy link
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preliminary review - may have additional comments, but wanted to get a couple of questions answered

@fvitt
restore factor setting
75ba203 
        modified:   src/chemistry/mozart/mo_lightning.F90
fvitt added 4 commits March 23, 2023 13:27
@fvitt
add LGHTNG_CLD2GRND diag
2eb1ca0 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
correct calc_nox_prod logic; misc clean up
5e75733 
        modified:   src/chemistry/mozart/mo_lightning.F90
@fvitt
minor cleanup
62edc57
@fvitt
revert setting of lght_no_prd_factor
f75b772 
        modified:   bld/build-namelist
@cacraigucar cacraigucar requested a review from jtruesdal March 27, 2023 23:27
brian-eaton
brian-eaton reviewed Mar 29, 2023
View reviewed changes
Copy link
Collaborator

@brian-eaton brian-eaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. A couple of minor comments.

nusbaume
nusbaume requested changes Mar 30, 2023
View reviewed changes
Copy link
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have one small change request and a question.

@brian-eaton brian-eaton self-requested a review March 30, 2023 18:14
jtruesdal
jtruesdal approved these changes Apr 4, 2023
View reviewed changes
Copy link
Collaborator

@jtruesdal jtruesdal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Ok to me.

@wwieder wwieder mentioned this pull request Apr 20, 2023
Closed
fvitt added 2 commits April 24, 2023 09:59
@fvitt
use ESCOMP/CMEPS tag
f236f1d 
	modified:   Externals.cfg
@fvitt
Jesse's change requests
af5d2b6 
	modified:   src/chemistry/mozart/mo_lightning.F90
	modified:   src/control/camsrfexch.F90
@fvitt fvitt requested review from nusbaume and cacraigucar April 24, 2023 16:30
@cacraigucar cacraigucar changed the title Cloud to ground lightning flash frequency passed to land model cam6_3_110?: Cloud to ground lightning flash frequency passed to land model Apr 24, 2023
@cacraigucar cacraigucar changed the title cam6_3_110?: Cloud to ground lightning flash frequency passed to land model part of cam6_3_109: Cloud to ground lightning flash frequency passed to land model Apr 25, 2023
@cacraigucar cacraigucar changed the title part of cam6_3_109: Cloud to ground lightning flash frequency passed to land model part of cam6_3_108: Cloud to ground lightning flash frequency passed to land model Apr 25, 2023
@fvitt fvitt mentioned this pull request Apr 25, 2023
Merged
@fvitt fvitt merged commit 47baa33 into ESCOMP:cam_development Apr 27, 2023
@adamrher adamrher mentioned this pull request May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gold2718 gold2718 gold2718 left review comments

@lkemmons lkemmons lkemmons left review comments

@brian-eaton brian-eaton brian-eaton approved these changes

@jtruesdal jtruesdal jtruesdal approved these changes

@cacraigucar cacraigucar cacraigucar approved these changes

@nusbaume nusbaume nusbaume approved these changes

Assignees

@fvitt fvitt

Labels
BFB bit for bit tag CoupledEval3
Projects
CAM Development
Status: Tag
Milestone
CESM3
Development

Successfully merging this pull request may close these issues.
8 participants
@fvitt @wwieder @gold2718 @brian-eaton @jtruesdal @cacraigucar @nusbaume @lkemmons