Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prescribing daily SSTs at the end of Feb/beginning of March in a leap year #190

Closed
islasimpson opened this issue Sep 4, 2022 · 5 comments
Closed

Prescribing daily SSTs at the end of Feb/beginning of March in a leap year #190

islasimpson opened this issue Sep 4, 2022 · 5 comments
Assignees
@jedwards4b @mvertens

Comments

@islasimpson
Copy link

Hello, Not sure if this is a CDEPS issue or my issue. I'm running with prescribed daily SSTs taken from the hires FOSI simulation and my simulation is crashing at 28th Feb/1st March 1964, which is my first leap year. I have made sure that my prescribed SST file says it is a noleap calendar and it has time values 1964-02-28 12:00:00 ... 1964-03-01 12:00:00. Input file is here... /glade/scratch/islas/RRAtlantic_SSTICE/SSTICE_hiresfosi_1964.nc

I'm getting the following error

Screenshot from 2022-09-04 07-29-11

which I see is coming from ./components/cdeps/streams/dshr_strdata_mod.F90. Run directory is here...

/glade/scratch/islas/f.e23.FAMIPfosi.ne0np4.NATL.ne30x8_t13.001/run

It is actually looking for 29th Feb in the data stream and crashing because there's a 2 day gap?

Thanks for any help.
@mvertens
Copy link
Collaborator

mvertens commented Sep 5, 2022

@islasimpson - I don't think its looking for 29th February - but the EMSF time calls thinks that between Feb.28 and Mar. 01 there is a 2 day gap - even though you have specifically specified that this is a no leap run. There is a hack that you could do to get past this point -but that will give slight wrong answers for just this one time interpolation - its to add the following line to your user_nl_docn_streams_file:
prescribed:dtlimit=2.0
In the meantime, I'll try to look at this next week.

@islasimpson
Copy link
Author

Thanks for your help. This did indeed successfully get be past the 29th February. Sorry for the slow response - am on vacation.

@jedwards4b
Copy link
Contributor

I think that this issue may be related. It is using cdeps0.12.63

@jedwards4b jedwards4b mentioned this issue Sep 23, 2022
Merged
jedwards4b added a commit that referenced this issue Sep 29, 2022
@jedwards4b
Merge pull request #191 from jedwards4b/leap_year_corrections
4d81662 
correct mismatch of leap year
### Description of changes
Handle a number of special cases in matching inputdata dates to model dates.
These cases are:

-   Model is no_leap, data is Gregorian and leapyear date 2/29 is encountered in data - skip date
-   Model is Gregorian, data is no_leap and leapyear date 2/29 is encountered in model - repeat 2/28 data
-   Model is Gregorian, data is gregorian but leapyears do not align.
-       if in model leap year repeat data from 2/28 
-       if in data leap year skip date 2/29


### Specific notes

Contributors other than yourself, if any:  @mvertens 

CDEPS Issues Fixed (include github issue #): #190 

Are there dependencies on other component PRs (if so list): ESCOMP/CESM_share#35

Are changes expected to change answers (bfb, different to roundoff, more substantial): bfb

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):  Neon spinup of over 100 years

Hashes used for testing:

sM  ./ccs_config
        modified sandbox, ccs_config_cesm0.0.44 (branch main) --> ccs_config_cesm0.0.38
    ./cime
        clean sandbox, on cime6.0.45
s   ./components/cdeps
        clean sandbox, 0f3f707 (branch leap_year_corrections) --> cdeps0.12.63
    ./components/cdeps/fox
        clean sandbox, on 4.1.2.1
    ./components/cdeps/share/genf90
        clean sandbox, on genf90_200608
    ./components/cism
        clean sandbox, on cismwrap_2_1_95
    ./components/cism/source_cism
        clean sandbox, on cism_main_2.01.011
 M  ./components/cmeps
        modified sandbox, on cmeps0.13.71
    ./components/cpl7
        clean sandbox, on cpl7.0.14
    ./components/mizuRoute
        clean sandbox, on 34723c2e4df7caa16812770f8d53ebc83fa22360
    ./components/mosart
        clean sandbox, on mosart1_0_45
    ./components/rtm
        clean sandbox, on rtm1_0_78
e-o ./doc/doc-builder
        -, not checked out --> v1.0.8
    ./libraries/mct
        clean sandbox, on MCT_2.11.0
    ./libraries/parallelio
        clean sandbox, on pio2_5_7
s   ./share
        clean sandbox, bfa2b5d0a9de06153f2ac94a95818568a1f5cf11 (branch shr_cal_leapyear) --> share1.0.12
    ./src/fates
        clean sandbox, on sci.1.58.1_api.24.1.0
@jedwards4b
Copy link
Contributor

@islasimpson has this issue been adequately addressed?

@islasimpson
Copy link
Author

This was adequately addressed for my purposes with Mariana's hack. I went with that option even though she said it would give slightly wrong answers for that interpolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jedwards4b jedwards4b

@mvertens mvertens

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jedwards4b @mvertens @islasimpson