Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow none mapalgo #138

Merged
merged 2 commits into from
Dec 16, 2021
Merged

Allow none mapalgo #138

merged 2 commits into from
Dec 16, 2021

Conversation

adrifoster
Copy link
Contributor

Description of changes

Allow none to be an option for mapalgo in the user_nl_datm_streams namelist file.

Specific notes

For single-point runs of CTSM, we need to be able to set foo:mapalgo=none , where foo is the stream name. I added none as an option to cime_config/stream_cdeps.py here:

valid_values["mapalgo"]  = ["bilinear", "nn", "redist", "mapconsd", "mapconf", "none"]

Contributors other than yourself, if any:
@billsacks and @ekluzek

CDEPS Issues Fixed (include github issue #): #134

Are there dependencies on other component PRs

  • CIME (list)
  • CMEPS (list)

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes - we allow mapalgo=none in the user_nl_datm_streams namelist
  • No

Testing performed:

  • (required) aux_cdeps
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Hashes used for testing:

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 15, 2021

I'm going to run the testing for this. I can't edit the original notes, but I'll add new notes here:

The externals I'm testing with are:

cime6.0.11
cmeps0.13.43
CTSM5.1.dev068

And I'll run aux_cdeps. I'll make sure that there is a test for this new option as well.

And I plan to look into #135 if it's easy to add to this.

@mvertens mvertens self-requested a review December 16, 2021 20:37
@mvertens mvertens merged commit fe4c788 into ESCOMP:master Dec 16, 2021
@adrifoster adrifoster deleted the allow_none_mapalgo branch August 10, 2022 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants