Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ozone DATM streams #188

Merged
merged 30 commits into from
Sep 2, 2022
Merged

Add ozone DATM streams #188

merged 30 commits into from
Sep 2, 2022

Conversation

adrifoster
Copy link
Contributor

@adrifoster adrifoster commented Aug 29, 2022

Description of changes

Add ozone DATM streams based on several input datasets.

Specific notes

  • ozone streams added for several different scenario types and compsets
  • logic set up in config_component to determine which stream goes with which compset by default
  • also added a hard-code creation and writing of a drv_flds_in file in buldnml
  • also fixed some minor bugs: file name was incorrect for stream presndep.SSP2-4.5, and missing stream for presaero.SSP5-8.5 added back

Contributors other than yourself, if any: @billsacks @mvertens

CDEPS Issues Fixed: #187

Are there dependencies on other component PRs: CMEPS (309)

Are changes expected to change answers: Yes, when the ozone DATM data is used (e.g. in CTSM) instead of previous hard-coded ozone values

Any User Interface Changes (namelist or namelist defaults changes): New ozone datm streams added (DATM_O3 can be clim_2000, clim_2010, clim_1850, hist, SSP2-4.5, SSP3-7.0, or SSP5-8.5).

General testing:

Performed tests to ensure the input ozone files matched reasonably well with output O3 from CTSM (see testing script /glade/u/home/afoster/analysis_scripts/Ozone_damage.ipynb). Example plots (global input/output difference at one time slice and then both input and output over one year at a single latitude and longitude)

bokeh_plot

bokeh_plot (1)

System testing:

Ran a comparison against cesm2_3_alpha09d baselines created with cdeps0.12.61 and found only NLCOMP fails for extra variable: flds_preso3

Tests ran:

  • ERS.T62_g37.G.cheyenne_gnu.pop-cice - /glade/scratch/afoster/cesm_tests/ERS.T62_g37.G.cheyenne_gnu.pop-cice.GC.20220830_120015_7f5l1o
  • ERS_IOP.T62_g16.GIAF.cheyenne_intel.pop-default - /glade/scratch/afoster/cesm_tests/ERS_IOP.T62_g16.GIAF.cheyenne_intel.pop-default.GC.20220830_120015_7f5l1o
  • SMS_Ld2_P72_D.T62_g37.C1850ECO.cheyenne_intel.pop-ecosys_81blocks_100x116_spacecurve - /glade/scratch/afoster/cesm_tests/SMS_Ld2_P72_D.T62_g37.C1850ECO.cheyenne_intel.pop-ecosys_81blocks_100x116_spacecurve.GC.20220830_120015_7f5l1o

Hashes used for testing:
cime6.0.52
cdeps0.12.62-26-g73bc63b
cmeps0.13.70-3-g2a3f929

@adrifoster
Copy link
Contributor Author

Redid some tests after adding extra compset logic:

Ran a comparison against cesm2_3_alpha09d baselines created with cdeps0.12.62 and found only NLCOMP fails for extra variable: flds_preso3

Tests ran:

ERS.T62_g37.G.cheyenne_gnu.pop-cice - /glade/scratch/afoster/cesm_tests_new/ERS.T62_g37.G.cheyenne_gnu.pop-cice.GC.20220830_144710_1hgaau
ERS_IOP.T62_g16.GIAF.cheyenne_intel.pop-default - /glade/scratch/afoster/cesm_tests_new/ERS_IOP.T62_g16.GIAF.cheyenne_intel.pop-default.GC.20220830_144710_1hgaau
SMS_Ld2_P72_D.T62_g37.C1850ECO.cheyenne_intel.pop-ecosys_81blocks_100x116_spacecurve - /glade/scratch/afoster/cesm_tests_new/SMS_Ld2_P72_D.T62_g37.C1850ECO.cheyenne_intel.pop-ecosys_81blocks_100x116_spacecurve.GC.20220830_144710_1hgaau
ERS_Lm3.T62_g17.AIAF.cheyenne_intel - /glade/scratch/afoster/cesm_tests_new//ERS_Lm3.T62_g17.AIAF.cheyenne_intel.GC.20220830_144710_1hgaau
ERS_Ld3.f45_g37_rx1.A.cheyenne_intel - /glade/scratch/afoster/cesm_tests_new/ERS_Ld3.f45_g37_rx1.A.cheyenne_intel.GC.20220830_144710_1hgaau

Hashes used for testing:
cime6.0.52
cdeps0.12.62-28-gbc449c5
cmeps0.13.70-3-g2a3f929

Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also run datm_cdeps_control_cfsr RT and it passed.

@mvertens mvertens merged commit ed418ee into ESCOMP:master Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add back presaero.SSP5-8.5 stream definition
4 participants