Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reusable workflow #201

Merged
merged 48 commits into from
Dec 23, 2022
Merged

Reusable workflow #201

merged 48 commits into from
Dec 23, 2022

Conversation

jedwards4b
Copy link
Contributor

Description of changes

Create reusable workflows and stop duplicating code

Specific notes

Contributors other than yourself, if any:

CDEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs (if so list):

Are changes expected to change answers (bfb, different to roundoff, more substantial):

Any User Interface Changes (namelist or namelist defaults changes):

Testing performed (e.g. aux_cdeps, CESM prealpha, etc):

Hashes used for testing:

@jedwards4b jedwards4b self-assigned this Dec 23, 2022
Copy link
Collaborator

@uturuncoglu uturuncoglu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jedwards4b This looks great. BTW, why we are not going with spack for the dependencies. I know you were working with it. You could get rid of all those actions.yaml files for each individual dependency. Maybe you are looking for more control over those dependency. Not sure.

@uturuncoglu
Copy link
Collaborator

@jedwards4b BTW, thanks for fixing ieee issue. I was not aware of that CPP flag. I am still using my own CDEPS for because of it but maybe I could switch to master after this PR in.

@jedwards4b jedwards4b merged commit 13ed25a into ESCOMP:master Dec 23, 2022
@jedwards4b
Copy link
Contributor Author

I have considered using spack and/or using containers and we may go there later, but for now I am happy to
just be able to remove a lot of redundant code and reuse more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants