remove shr_mpi_mod #203
Merged
remove shr_mpi_mod #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uturuncoglu
approved these changes
Dec 28, 2022
There was a problem hiding this comment.
@jedwards4b Thanks for replacing all those MPI calls with their ESMF equivalents.
|
@jedwards4b - thank you for taking this on! |
|
@mvertens @uturuncoglu - This is ready to merge, do you want to test against UFS or reexamine source changes? |
|
@jedwards4b let me run one case from UFS. I'll update you. |
uturuncoglu
reviewed
Dec 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove shr_mpi_mod and replace with ESMF_VM operations.
Specific notes
Contributors other than yourself, if any:
CDEPS Issues Fixed: #38
Are there dependencies on other component PRs (if so list):
Are changes expected to change answers: bfb
Any User Interface Changes (namelist or namelist defaults changes): no
Testing performed (e.g. aux_cdeps, CESM prealpha, etc): aux_cdeps on cheyenne intel, all pass.
Hashes used for testing:
s ./ccs_config
clean sandbox, main --> ccs_config_cesm0.0.49
s ./cime
clean sandbox, master --> cime6.0.75
./components/cam
clean sandbox, on cam6_3_085
./components/cam/chem_proc
clean sandbox, on chem_proc5_0_05
./components/cam/src/atmos_phys
clean sandbox, on atmos_phys0_00_011
./components/cam/src/dynamics/fv3/atmos_cubed_sphere
clean sandbox, on fv3_cesm.04
./components/cam/src/dynamics/mpas/dycore
clean sandbox, on ff76a231ddf6bfd3bdb878afb02821c70ba1a856
./components/cam/src/physics/ali_arms
clean sandbox, on ALI_ARMS_v1.0.0
./components/cam/src/physics/carma/base
clean sandbox, on carma4_00
./components/cam/src/physics/clubb
clean sandbox, on larson-group/clubb_release/tags/clubb_4ncar_20220311_f51de38/src/CLUBB_core
./components/cam/src/physics/cosp2/src
clean sandbox, on CFMIP/COSPv2.0/tags/v2.1.4cesm/src
./components/cam/src/physics/pumas
clean sandbox, on pumas_cam-release_v1.27
./components/cam/src/physics/pumas-frozen
clean sandbox, on pumas_cam-release_v1.17_rename
./components/cam/src/physics/silhs
clean sandbox, on larson-group/clubb_release/tags/clubb_4ncar_20220311_f51de38/src/SILHS
s ./components/cdeps
clean sandbox, no_gfortan_warnings --> cdeps0.12.67
./components/cdeps/fox
clean sandbox, on 4.1.2.1
./components/cdeps/share/genf90
clean sandbox, on genf90_200608
./components/cice
clean sandbox, on cesm_cice6_2_0_34
./components/cice/src
clean sandbox, on cice6_20211214q
./components/cice/src/icepack
clean sandbox, on 7c33d8ebeaa42d3d76767b7825730a9c2a555ec2
./components/cice5
clean sandbox, on cice5_20220128
./components/cism
clean sandbox, on cismwrap_2_1_95
./components/cism/source_cism
clean sandbox, on cism_main_2.01.011
./components/clm
clean sandbox, on ctsm5.1.dev114
./components/clm/src/fates
clean sandbox, on sci.1.59.7_api.24.1.0
s ./components/cmeps
clean sandbox, pio_asyncio_in_cmeps --> cmeps0.14.0
./components/cpl7
clean sandbox, on cpl7.0.14
o ./components/mom
clean sandbox, on mi_221206
sM ./components/mom/MOM6
modified sandbox, cesm_logging_improvements --> dev/ncar_221119
./components/mom/MOM6/pkg/CVMix-src
clean sandbox, on v0.98-beta
./components/mom/MOM6/pkg/GSW-Fortran
clean sandbox, on 29e64d652786e1d076a05128c920f394202bfe10
./components/mosart
clean sandbox, on mosart1_0_47
./components/pop
clean sandbox, on cesm_pop_2_1_20220322
./components/pop/externals/CVMix
clean sandbox, on v0.98-beta
./components/pop/externals/MARBL
clean sandbox, on marbl0.40.3
s ./components/rtm
clean sandbox, master --> rtm1_0_78
./components/ww3
clean sandbox, on ww3_221108
o ./components/ww3dev
clean sandbox, on main_0.0.5
M ./components/ww3dev/WW3
modified sandbox, on dev/unified_0.0.5
s o ./libraries/FMS
clean sandbox, FMS_update_to2021.03.01 --> fi_20220425
./libraries/FMS/src
clean sandbox, on 2021.03.01
./libraries/mct
clean sandbox, on MCT_2.11.0
sM ./libraries/parallelio
modified sandbox, pio2_5_10 --> pio2_5_9
sM ./share
modified sandbox, main --> share1.0.13
o ./tools/statistical_ensemble_test/pyCECT
clean sandbox, on 3.2.2