Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

the build in github was not consistant with that outside github #209

Merged
merged 2 commits into from
Jan 17, 2023
Merged

the build in github was not consistant with that outside github #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70817b7
the build in github was not consistant with that outside github, this…
jedwards4b Jan 14, 2023
ea9e05b
add flag --warn-no-unused-dummy-argument so that we do not error on t…
jedwards4b Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/extbuild.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,6 @@ jobs:
export SRC_ROOT=
mkdir build-cdeps
pushd build-cdeps
cmake -Wno-dev -DCMAKE_BUILD_TYPE=DEBUG -DCMAKE_Fortran_FLAGS="-DCPRGNU -g -Wall -ffree-form -ffree-line-length-none -fallow-argument-mismatch -Wno-unused-dummy-argument " -DWERROR=ON ../
cmake -Wno-dev -DCMAKE_BUILD_TYPE=DEBUG -DCMAKE_Fortran_FLAGS="-DCPRGNU -g -Wall -ffree-form -ffree-line-length-none -fallow-argument-mismatch " -DWERROR=ON ../
make VERBOSE=1
popd
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ foreach(COMP datm dice dlnd docn drof dwav)
$<INSTALL_INTERFACE:mod>)

if(WERROR)
target_compile_options(${COMP} PRIVATE -Werror)
target_compile_options(${COMP} PRIVATE -Werror --warn-no-unused-dummy-argument)
endif()
install(TARGETS ${COMP}
EXPORT ${COMP}
Expand All @@ -118,7 +118,7 @@ foreach(DEPS streams dshr cdeps_share FoX_dom FoX_wxml FoX_sax FoX_common FoX_ut
string(SUBSTRING ${DEPS} 0 3 fox)
if(WERROR AND NOT ${fox} STREQUAL "FoX")
message("Adding Werror flag to ${DEPS} (fox = ${fox})")
target_compile_options(${DEPS} PRIVATE -Werror)
target_compile_options(${DEPS} PRIVATE -Werror --warn-no-unused-dummy-argument)
endif()

install(TARGETS ${DEPS}
Expand Down