Change long names for CISM compsets #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly put GRIS (for Greenland Ice Sheet) in the long name. This shouldn't change any behavior. CISM has been backwards compatible in this respect, but making this compset long name change will allow us to remove the backwards compatibility code in CISM. Resolves ESCOMP#181
fischer-ncar
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Explicitly put GRIS (for Greenland Ice Sheet) in the long name. This
shouldn't change any behavior. CISM has been backwards compatible in
this respect, but making this compset long name change will allow us to
remove the backwards compatibility code in CISM.
Specific notes
Contributors other than yourself, if any: none
Fixes #181
User interface changes?: No
Testing performed (automated tests and/or manual tests):