Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changes to satisfy ufsatm and cesm requirements for pot temp and density from atm #3

Merged
merged 1 commit into from
May 26, 2020
Merged

changes to satisfy ufsatm and cesm requirements for pot temp and density from atm #3

merged 1 commit into from
May 26, 2020

Conversation

mvertens
Copy link

@mvertens mvertens commented May 25, 2020 •
edited
Loading

changes to satisfy ufsatm and cesm requirements for pot temp and density from atm

For detailed information about submitting Pull Requests (PRs) to the CICE-Consortium,
please refer to: https://github.com/CICE-Consortium/About-Us/wiki/Resource-Index#information-for-developers

PR checklist

  • Short (1 sentence) summary of your PR:
    Rather than have calculations done in the CMEPS mediator, it was decided based on joint discussions with EMC that the cice6 noupc cap for cmeps should be able to adapt to the requirements of both UFSATM and CESM.
  • Developer(s):
    Mariana Vertenstein, Denise Worthen
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    • verified that running SMS_Vnuopc_Ld1.T62_g37.DTEST.cheyenne_intel remained bfb with respect to the origin cap.
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:
    None

@mvertens mvertens requested a review from dabail10 May 25, 2020 00:14
@dabail10 dabail10 merged commit 7e43703 into ESCOMP:nuopc May 26, 2020
mvertens referenced this pull request in NorESMhub/CICE Apr 27, 2023
@dabail10 @eclare108213
Local Solar Time Computation (CICE-Consortium#323)
804b703 
* Fix local solar time

* Add line for going past 24

* New LST calculation

Addresses #3.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabail10 dabail10 dabail10 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mvertens @dabail10