Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write diags to a seperate file #178

Merged
merged 2 commits into from
May 5, 2021
Merged

Conversation

jedwards4b
Copy link
Collaborator

Description of changes

Create a diags.log file with the budget calculation results, this is moved from med.log

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines: cheyenne / intel
    • details (e.g. failed tests):
  • (recommended) CESM testlist_drv.xml
    • machines and compilers:
    • details (e.g. failed tests):
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail
    • machines and compilers
    • details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:

@jedwards4b jedwards4b requested a review from mvertens May 4, 2021 17:11
@jedwards4b jedwards4b self-assigned this May 5, 2021
@mvertens
Copy link
Collaborator

mvertens commented May 5, 2021

@jedwards4b - thanks this looks very good. We should have @DeniseWorthen review this as well. I don't think this will touch the UFS code - but it would be good to have her accept the PR as is.

@DeniseWorthen
Copy link
Collaborator

I did compile and run our simplest case just to confirm that the retrieval of the new attribute worked for us. It did so we're fine w/ this change.

@jedwards4b jedwards4b requested a review from DeniseWorthen May 5, 2021 21:26
@jedwards4b jedwards4b merged commit bb7c520 into ESCOMP:master May 5, 2021
@jedwards4b jedwards4b deleted the diags_out_file branch May 5, 2021 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants