Bug fixes for CESM 1850 mct/nuopc validation #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@uturuncoglu @DeniseWorthen - this PR should not effect the UFS configuration. @jedwards4b is on vacation - so if you both could review and hopefully accept this - I will merge. |
uturuncoglu
approved these changes
May 20, 2021
|
@DeniseWorthen - are you okay with this PR? If so can you please sign off on it. |
DeniseWorthen
approved these changes
Jun 1, 2021
jedwards4b
approved these changes
Jun 1, 2021
|
@mvertens why did the change you make fix a memory leak? Was it an issue associated with a compiler bug or did you find a bug in cmeps? |
|
@jedwards4b - I found a bug in cmeps and included a fix in this PR.
…On Tue, Jun 1, 2021 at 7:55 AM jedwards4b ***@***.***> wrote:
@mvertens <https://github.com/mvertens> why did the change you make fix a
memory leak? Was it an issue associated with a compiler bug or did you find
a bug in cmeps?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#195 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB4XCEZIZQ6MKAFJYLLBESLTQTRFJANCNFSM45HOY26Q>
.
--
Mariana Vertenstein
CESM Software Engineering Group Head
National Center for Atmospheric Research
Boulder, Colorado
Office 303-497-1349
Email: ***@***.***
|
|
@mvertens can you point out the bug fix? It's hard to spot given all of the format changes in med_diag_mod.F90 |
|
@jedwards4b - its the addition of 2 new deallocate statements (for afrac and sfrac). Also - its removing the embedded routines with multiple level of contains and making them separate routines as part of this. |
|
great, thanks for clarifying |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Bug fixes for CESM 1850 mct/nuopc validation - including memory leak in med_diag_mod.F90.
Specific notes
These are changes needed to the budgets and run sequence needed that were needed to fix problems in the B1850 mct/nuopc validation.
Contributors other than yourself, if any: @jedwards4b
CMEPS Issues Fixed: #190 #197
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):
5 year B1850 1 year simulation was run
Hashes used for testing: