Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused namelist variables #199

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

billsacks
Copy link
Member

Description of changes

Remove some unused namelist variables: glc_nx, glc_ny, and some glc2lnd and lnd2glc mapping file variables.

In addition to doing some general cleanup, the motivation for removing these is because they will be hard to support with the upcoming capability to have multiple GLC grids.

Specific notes

Contributors other than yourself, if any: @mvertens provided general input

CMEPS Issues Fixed (include github issue #): none

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes - just removes some namelist and xml variables
  • No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

  • (recommended) CIME_DRIVER=nuopc scripts_regression_tests.py
    • machines: cheyenne
    • details (e.g. failed tests):
      • Testing run in the context of cesm2_3_beta03
      • Two tests failed; these also fail from out-of-the-box cesm2_3_beta03:
        • test_j_createnewcase_user_compset_vs_alias
        • ERIO_Ln11.f09_g16.X.cheyenne_intel from test_full_system
  • (recommended) CESM testlist_drv.xml
    • machines and compilers: cheyenne; all compilers for which tests are defined
    • details (e.g. failed tests):
      • Ran tests in xml category nuopc; did not perform baseline comparisons
      • Three tests failed; I'm pretty sure these are due to pre-existing issues:
        • ERR_Vnuopc_Ld5.f09_t061.B1850MOM.cheyenne_intel.allactive-nuopc_cap_io & ERS_Vnuopc_Ld5.f19_g17.B1850.cheyenne_intel.allactive-nuopc_cap_io: can't find nuopc_cap_io testmods dir
        • ERS_Vnuopc_Lm13.f10_f10_mg37.I1850Clm50SpG.cheyenne_intel: Can't do restart run with CISM & NUOPC currently
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):
  • (other) please described in detail: CISM's aux_glc test suite
    • machines and compilers: cheyenne intel & gnu
    • details (e.g. failed tests):
      • Tests run in the context of cismwrap_2_1_85
      • All tests pass and are bit-for-bit with baselines; NLCOMP failures as expected

Testing performed if application target is UFS-coupled:

  • (recommended) UFS-coupled testing
    • description:
    • details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

  • (recommended) UFS-HAFS testing
    • description:
    • details (e.g. failed tests):

Hashes used for testing:

  • CESM:
  • UFS-coupled, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:
  • UFS-HAFS, then umbrella repostiory to check out and associated hash:
    • repository to check out:
    • branch:
    • hash:

billsacks added 2 commits May 28, 2021 15:58
These don't appear to be needed in the drv, and trying to support them
will be tricky with multiple ice sheets.
There were some remnants of the lnd2glc and glc2lnd mapping file
variables that weren't actually referenced in the code. This commit
removes them.

Note that we *do* still need these maps, but with changes Mariana
Vertenstein put in place a few months ago, it is assumed that these maps
are always generated at runtime. (If we later want to go back to
supporting these maps being provided as pre-generated files, this commit
should be reverted and some other code should be added back in to
actually use the relevant variables.)
@mvertens mvertens merged commit 656198e into ESCOMP:master Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants