Simplify logic for glc_renormalize_smb #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the glc_renormalize_smb option on_if_glc_coupled_fluxes. This had been the default. Change the default to 'on'. This maintains consistent behavior between different configurations. Changes answers for T compsets. Resolves ESCOMP#133
|
@mvertens @whlipscomb @Katetc - this (finally) resolves #133 in the way we discussed there a few years ago. Note that this will change answers for T compsets, because now the SMB renormalization is always on by default (but it can still be turned off if desired). |
billsacks
added a commit
to billsacks/CISM-wrapper
that referenced
this pull request
Aug 9, 2024
Rework documentation of glc_renormalize_smb to be consistent with the changes in ESCOMP/CMEPS#495
mvertens
approved these changes
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Remove the glc_renormalize_smb option on_if_glc_coupled_fluxes. This had been the default. Change the default to 'on'. This maintains consistent behavior between different configurations.
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #): Resolves #133
Are changes expected to change answers? YES: changes answers by greater than roundoff for T compsets (active GLC with DLND) (now SMB is remapped with renormalization for T compsets by default); answers should be bit-for-bit in all other configurations (unless there is some configuration/combination that I'm not thinking of...)
Any User Interface Changes (namelist or namelist defaults changes)? Removes
on_if_glc_coupled_fluxesoption toglc_renormalize_smbTesting performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing
Tested in the context of
cesm3_0_beta02: ran:All tests passed; the T compset test changed answers as expected but the other two were bit-for-bit.