-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wav2ocn and ocn2wav maps are still needed in some cases #498
Conversation
@@ -1405,6 +1405,22 @@ | |||
<desc>rof2ocn runoff mapping file</desc> | |||
</entry> | |||
|
|||
<entry id="OCN2WAV_SMAPNAME"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you want something of the form
char
mapping
MED_attributes
ocn to wav mapping, 'unset' or 'idmap' are normal possible values
unset
idmap
And set samegrid_ocn_wav in buildnml. It doesn't make sense to have idmap be the default value if the two are on different grids.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
However, do we really want to have these as xml variables - or just add them in as namelist variables in case the user might want to change them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe there is a format error in your comment - if you meant to include xml can you wrap it in <CODE></CODE>.
Also I don't see a variable samegrid_ocn_wav in the cmeps buildnml. I'm not sure what you want.
<file>env_run.xml</file> | ||
<desc>wav2ocn state mapping file</desc> | ||
</entry> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same comment as above.
Description of changes
Reintroduce wav2ocn and ocn2wav map xml variables.
Specific notes
Contributors other than yourself, if any: mvertens
CMEPS Issues Fixed (include github issue #):
Are changes expected to change answers? (specify if bfb, different at roundoff, more substantial)
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed
Please describe the tests along with the target model and machine(s)
If possible, please also added hashes that were used in the testing