Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SMYLE use-case setup #1197

Closed
ekluzek opened this issue Oct 28, 2020 · 8 comments
Closed

SMYLE use-case setup #1197

ekluzek opened this issue Oct 28, 2020 · 8 comments
Assignees
Labels
branch tag: release Changes go on release branch as well as master enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Oct 28, 2020

Bring in a user-mod directory on the release-clm5.0 branch that implements the following for CLM:

https://docs.google.com/document/d/1rV3fWCIt-D1fAbzQ6uaQeZyLagzzKnopofr88eXegzY

@ekluzek ekluzek added enhancement new capability or improved behavior of existing capability branch tag: release Changes go on release branch as well as master tag: enh - new science labels Oct 28, 2020
@ekluzek ekluzek self-assigned this Oct 28, 2020
@ekluzek
Copy link
Collaborator Author

ekluzek commented Oct 28, 2020

I'll also work with someone on CAM for this

ESCOMP/CAM#256

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 4, 2020

I have a branch tag for this now: branch_tags/smyle.n01_release-clm5.0.34

@ekluzek
Copy link
Collaborator Author

ekluzek commented Nov 10, 2020

OK, we need a user mod for 1850 and a separate one for Historical. And for 1850 we need a TRENDY surface dataset for that as TRENDY used 1700. I've done that and created a new tag: branch_tags/smyle.n02_release-clm5.0.34

@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 5, 2021

Working with @nanr we found we needed to separate out the versions for stand-alone and coupled (otherwise the coupled one fails when trying to set DATM settings and especially trying to copy a datm namelist changes in SourceMods). I also changed it so that the user-mod is set when a %SMYLE setting is used for the compset name. This version is branch_tags/smyle.n03_release-clm5.0.34

@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 5, 2021

We decided we should further work on this and make the smyle non-history changes into a use-case so it's more embedded into the namelist build. This means you don't have to append further changes onto the user_nl_clm, but can do a complete replacement of the user_nl_clm without losing anything.

@nanr also found that there was a typo in the filenames for the TRENDY files.

@ekluzek ekluzek mentioned this issue Apr 7, 2021
@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 2, 2022

@jedwards4b has a PR that changes the 1850 user-mod directory into a use-case for SMYLE. #1614. I think the other two user-mod directories need to be handled similarly.

@ekluzek ekluzek changed the title SMYLE user-modification directory SMYLE use-case setup Feb 8, 2022
@ekluzek
Copy link
Collaborator Author

ekluzek commented Feb 8, 2022

The PR #1328 implemented this using user-mod directories. That approach was complex and the use-cases in #1614 are a better way to do it. At this point I think everything in the first is in #1614, although that could be checked. But, we need to make sure these are correct for what needs to be done for SMYLE.

@ekluzek
Copy link
Collaborator Author

ekluzek commented May 11, 2023

This was already merged and in place for SMYLE, so closing.

@ekluzek ekluzek closed this as completed May 11, 2023
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch tag: release Changes go on release branch as well as master enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
None yet
Development

No branches or pull requests

2 participants