Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smyle L83 compset and SSP3-7.0 extension #1614

Merged
merged 35 commits into from
Feb 8, 2022

Conversation

jedwards4b
Copy link
Contributor

@jedwards4b jedwards4b commented Jan 25, 2022

Description of changes

Adds a compset for the smyle L83 model. BWsc1850smyle

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #):
Fixes #1197
Fixes #1633
Fixes #1632
Fixes #1631
Fixes #1578
Fixes #1131
Fixes #1093
Fixes #1036
Fixes #738

Are answers expected to change (and if so in what way)? SSP3-7.0, SSP2-4.5 and SSP5-3.4 because of ndep files
Except for when using the new smyle use-cases
Spinup cases (such as the SSP tests) change answers because of #738

Any User Interface Changes (namelist or namelist defaults changes)? Addition of new smyle use-case

Testing performed, if any: regular testing will be done.

sunnivin and others added 3 commits November 12, 2020 15:01
…/main/controlMod.F90 l804 (pointed out by @olyson and @billsacks) ESCMP/CTSM#1191:

call mpi_bcast (hist_avgflag_pertape, size(hist_avgflag_pertape), MPI_CHARACTER, 0, mpicom, ier)
-->
call mpi_bcast (hist_avgflag_pertape, len(hist_avgflag_pertape)*size(hist_avgflag_pertape), MPI_CHARACTER, 0, mpicom, ier)

mpi_bcast should be replaced with shr_mpi_bcast in the whole suproutine in the future.
@ekluzek ekluzek self-assigned this Jan 25, 2022
@ekluzek ekluzek added tag: enh - new science enhancement new capability or improved behavior of existing capability labels Jan 25, 2022
@ekluzek
Copy link
Collaborator

ekluzek commented Jan 25, 2022

@jedwards4b thanks for putting this together and pointing us to it.

I have a question that I think is mainly for @billsacks.

This has history file settings in the use-case. Overall we've avoided doing that in CTSM, and put history settings either in build-namelist or in user-mod directories rather than use-cases. I'm not sure that putting them in a use-case is a bad thing to do -- just that we've avoided doing that. So I wanted to hear if anyone knows if there are reasons why not to put them in use-cases? It does potentially have problems if certain configurations turn off some of the history fields that are in the list. But, that would be OK, if the SMYLE use-case isn't going to be used in that situation. I asked the same question of the CAM folks also.

I do see that we did do this sort of thing for the use-case stdurbpt_pd.xml, but that's an uncommon case. For CMIP6 history settings we put those in user-mod directories. And we have some user-mod directories for high-frequency output as well.

@ekluzek ekluzek added branch tag: release Changes go on release branch as well as master next this should get some attention in the next week or two. Normally each Thursday SE meeting. labels Jan 25, 2022
@billsacks
Copy link
Member

We decided to use user mods directories for other history file settings mostly because it makes it easier and less error-prone for users to customize the starting point: with a user mods directory, you have a user_nl_clm starting point that you can then change (adding or removing history fields as needed). This is more awkward and error-prone if you are setting history settings under the covers via a use case or namelist defaults.

@ekluzek
Copy link
Collaborator

ekluzek commented Jan 25, 2022

Yes, that makes sense, and I think it would apply here. We could still have a use-case for some of the settings, but a user-mod directory for the history part of this. You are right that is the part that users are the most likely to mess with and change from one case to another.

@jedwards4b
Copy link
Contributor Author

I have removed the history file changes to user_mods in https://github.com/jedwards4b/CESM2-Realtime-Forecast/
which is used to generate and run ensembles for the smyle experiment.

This was referenced Feb 2, 2022
@jedwards4b
Copy link
Contributor Author

I redid the use case as 20thC_smyle_transient.xml, however to avoid having to make changes to other components
I kept the compset name of BWsc1850smyle

@ekluzek
Copy link
Collaborator

ekluzek commented Feb 2, 2022

Hey @jedwards4b I just want to send a "Are you sure"? cautionary note. :-)

First it looks to me that we'll want to update the last years for some of the transient datasets being used. And actually I think we want to use the SSP scenario for some of these so that we have data beyond 2015.

The second concern is that do we really want to have some data transient for CLM, but fixed 1850 for other components? If that's correct, that's fine. If not we may want to change the compset even though it will require other components to change. It's also good to have our compsets follow the standard patterns, otherwise we end up having problems down the line when we forget about the exception we made.

It's just good to get this right, before simulations are run, even if that means a little more work up front.

@ekluzek ekluzek changed the title add smyle L83 compset add smyle L83 compset and SSP3-7.0 extension Feb 6, 2022
@ekluzek ekluzek merged commit 980b655 into ESCOMP:release-clm5.0 Feb 8, 2022
@ekluzek ekluzek deleted the clm5.0_smyleL83 branch February 8, 2022 23:12
@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label May 12, 2022
@samsrabin samsrabin added the science Enhancement to or bug impacting science label Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch tag: release Changes go on release branch as well as master enhancement new capability or improved behavior of existing capability science Enhancement to or bug impacting science
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants