Error in NEON surface datasets for agricultural sites

[wwieder]

Brief summary of bug

Subset data wasn't used correctly for agricultural NEON sites (STER and KONA), where PCT_CFT is not 100% rainfed spring wheat, as intended.

ncdump -v PCT_CFT /glade/p/cesmdata/cseg/inputdata/lnd/clm2/surfdata_map/NEON/surfdata_hist_78pfts_CMIP6_simyr2000_KONA_c210831.nc

 PCT_CFT =
  0,
  0,
  27.498169756034,
  0,
  12.2062509947551,
...

This requires using the --crop flag in ./subset_data, as below
./subset_data point --lat 39.10828 --lon -96.61044 --site KONA --dompft 19 --crop --create-surface

** One clarification, @ekluzek is this correct for rainfed spring wheat? **See Table 26.1 in the tech note.

which is subsequently modified for soil properties
./modify_singlept_site_neon.py --neon_site KONA

Updated files are available /glade/scratch/wwieder/single_point_neon_updated/, which seems to be handled correctly

ncdump -v PCT_CFT /glade/scratch/wwieder/single_point_neon_updated/surfdata_0.9x1.25_hist_78pfts_CMIP6_simyr2000_STER_c221014.nc

 PCT_CFT =
  0,
  0,
  0,
  0,
  100,
  0,

...

• If this all looks correct, @ekluzek can these be moved to inputdata?
• Subsequently, will the run_neon script automatically point to these latest files?
• Finally we'll also have to modify this information in the neon_sites file

[wwieder]

These files are also not working as intended because PCT_NAT_PFT > 100 with modifications made to bare ground, but not other pfts. In the 'old' surface data these values have all been zeroed out. I'll do that manually now, using

This was caused by an error in modify_singlept_site_neon.py that was manually overwriting
PCT_NAT_PFT.values[0] = [[100.0]], which I don't think is necessary.

• We need to fix modify_singlept_site_neon.py so this is handled this correctly.

[wwieder]

@ekluzek new surface data are available here /glade/scratch/wwieder/single_point_neon_updated

I'll open a PR for the code modifications