Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve misleading error message in check_for_nans #1896

Closed
billsacks opened this issue Nov 10, 2022 · 0 comments · Fixed by #1872
Closed

Improve misleading error message in check_for_nans #1896

billsacks opened this issue Nov 10, 2022 · 0 comments · Fixed by #1872
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability simple easy for anyone to work on

Comments

@billsacks
Copy link
Member

The check_for_nans routine is used to check import and export fields to / from CTSM for NaN values. However, even though this same function is used for both imports and exports, the error message is always, "One or more of the output from CLM to the coupler are NaN".

We should add an argument to this subroutine saying whether it's being used for import or export and adjust the text in the error message accordingly, so that it either reads "One or more of the outputs from CTSM to the coupler are NaN" or "One or more of the inputs from the coupler to CTSM are NaN".

@billsacks billsacks added enhancement new capability or improved behavior of existing capability tag: simple bfb labels Nov 10, 2022
@ekluzek ekluzek mentioned this issue Nov 14, 2022
ekluzek added a commit to wwieder/ctsm that referenced this issue Nov 14, 2022
@samsrabin samsrabin added simple easy for anyone to work on bfb bit-for-bit labels Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bfb bit-for-bit enhancement new capability or improved behavior of existing capability simple easy for anyone to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants