Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run_neon base case must be of same run type as a requested clone #1926

Open
wwieder opened this issue Dec 13, 2022 · 0 comments
Open

run_neon base case must be of same run type as a requested clone #1926

wwieder opened this issue Dec 13, 2022 · 0 comments
Assignees
Labels
bug something is working incorrectly documentation additions or edits to user-facing documentation

Comments

@wwieder
Copy link
Contributor

wwieder commented Dec 13, 2022

Brief summary of bug

Creating a default NEON case with ./run_neon generates a base case and a transient simulation. Subsequently running with --run-type ad from that original base case fails. Bug is resolved when the base case is created as the same run type as the cases being cloned from it.

General bug information

CTSM version you are using: latest dev tag ctsm5.1.dev115
Thanks to @TeaganKing for first identifying this bug.

Does this bug cause significantly incorrect results in the model's science?

No, but is potentially confusing and frusterating for users

Configurations affected:

NEON single point cases created with .run_neon script

Details of bug

I created a NEON case with the following command, which creates a base case BART and transient case, BART.transient. This simulation runs fine
./run_neon.py --neon-sites BART --neon-version v2

Subsequently cloning a BART.ad case from that base case, however, fails.
./run_neon.py --neon-sites BART --neon-version v2 --run-type ad --base-case BART

These errors can be avoided by creating the base case as the same run type as subsequent clones. For example the following create and runs a ABBY base case that works fine for cloning other .ad simulations

./run_neon.py --neon-sites ABBY --neon-version v2 --run-type ad
./run_neon.py --neon-sites MOAB --neon-version v2 --run-type ad --base-case ABBY

Important output or errors that show the problem

The cesm.log error states

ERROR: (shr_stream_findBounds) ERROR: rDateIn lt rDatelvd limit true

The atm.log error states

(shr_strdata_get_stream_pointer_1d)  strm_ptr is allocated for stream field strm_Faxa_precn
 (shr_stream_findBounds) ERROR: limit on and rDateIn lt rDatelvd
   180101.000000000        20180101.0000000

Definition of done.

In the short term, we can document this in tech note / user's guide, or tutorials for NEON simulations, #1494
Could also be addressed with testing, improvements, and migration of .run_neon into python directory,
#1906, #1441. This could be simply failing to clone a base case that's not compatible with the requested run-type, or backing out the features that are causing this incompatibility in the first place (which is likely harder)?

@wwieder wwieder added documentation additions or edits to user-facing documentation bug something is working incorrectly labels Dec 13, 2022
@wwieder wwieder added this to the NEON milestone Dec 13, 2022
@ekluzek ekluzek added the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Dec 15, 2022
@billsacks billsacks removed the next this should get some attention in the next week or two. Normally each Thursday SE meeting. label Jan 26, 2023
@ekluzek ekluzek removed this from the NEON milestone Apr 25, 2024
@samsrabin samsrabin added this to the ctsm6.0.0 (code freeze) milestone May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug something is working incorrectly documentation additions or edits to user-facing documentation
Projects
Development

No branches or pull requests

5 participants