Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scripts no longer needed with mksurfdata_esmf #2180

Closed
4 tasks done
ekluzek opened this issue Sep 29, 2023 · 1 comment
Closed
4 tasks done

Remove scripts no longer needed with mksurfdata_esmf #2180

ekluzek opened this issue Sep 29, 2023 · 1 comment
Assignees
Labels
code health improving internal code structure to make easier to maintain (sustainability)
Milestone

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Sep 29, 2023

Some scripts that were useful a long time ago before check_input_data, query_config and other's were created are:

listDefaultNamelist.pl
queryDefaultNamelist.pl queryDefaultXML.pm
checkmapfiles.ncl
createMapEntry.pl
createMkSrfEntry.py
getco2_historical.ncl

These all were required with mksurfdata_map, but with mksurfdata_esmf no longer are so should be removed.

Definition of done:

  • Remove all the files
  • Update README files for the change
  • Update any other documentation
  • Make sure both the code and tools work
@ekluzek ekluzek added the code health improving internal code structure to make easier to maintain (sustainability) label Sep 29, 2023
@ekluzek ekluzek added this to the ctsm5.2.0 milestone Sep 29, 2023
@ekluzek ekluzek self-assigned this Sep 29, 2023
@ekluzek
Copy link
Collaborator Author

ekluzek commented Sep 29, 2023

Note, that getco2_historical.ncl also used queryDefaultNamelist. It's only needed if new CO2 datasets are created that need to be converted into streams format. Since, this may only happen with CMIP7 this capability isn't needed soon. Our process may not require it when CMIP7 comes. And since this code is in NCL would need to be replaced with something else anyway. So we might as well wait to see if it's required and then do whatever is appropriate at that time.

@ekluzek ekluzek changed the title Remove scripts now longer needed with mksurfdata_esmf Remove scripts no longer needed with mksurfdata_esmf Oct 2, 2023
ekluzek added a commit to ekluzek/CTSM that referenced this issue Dec 31, 2023
@ekluzek ekluzek closed this as completed Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code health improving internal code structure to make easier to maintain (sustainability)
Projects
No open projects
Development

No branches or pull requests

1 participant