Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do any updates of water tracers needed in dynSubgrid_driver #488

Closed
billsacks opened this issue Aug 30, 2018 · 0 comments
Closed

Do any updates of water tracers needed in dynSubgrid_driver #488

billsacks opened this issue Aug 30, 2018 · 0 comments
Assignees
@billsacks
Labels
enhancement new capability or improved behavior of existing capability

Comments

@billsacks
Copy link
Member

One of the first driver calls is dynSubgrid_driver. To get tracer consistency checks to pass early in the driver loop, we'll need to update any tracer variables related to variables updated in dynSubgrid_driver.
@billsacks billsacks added the enhancement new capability or improved behavior of existing capability label Aug 30, 2018
@billsacks billsacks self-assigned this Aug 30, 2018
@billsacks billsacks mentioned this issue Nov 21, 2018
Merged
billsacks added a commit that referenced this issue Nov 29, 2018
@billsacks
Merge branch 'initial_tracer_updates'
5ba4739 
Water tracer updates for initial things in driver loop

Update water tracers for initial stuff done in driver loop. This
includes atm2lnd forcings (non-downscaled and downscaled), balance check
initialization, and dyn subgrid updates.

Broadly speaking, the changes here are:

(1) Reworked WaterType to make it easier / more robust for other code to
    loop over tracers or bulk+tracers

(2) The most interesting changes are probably the code to update the
    atm2lnd water tracers (in Wateratm2lndType.F90 and
    WaterTracerUtils.F90)

(3) In various other places, do some infrastructurey stuff (initializing
    water balance, doing dyn subgrid stuff) for tracers as well as bulk

(4) Supporting unit tests and unit test infrastructure

Resolves #487
Resolves #488
Resolves #489
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@billsacks billsacks

Labels
enhancement new capability or improved behavior of existing capability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billsacks