Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling of deg/rad and -180-180 vs. 0-360 in CLM input files.. #89

Open
ekluzek opened this issue Dec 16, 2017 · 1 comment
Open

Handling of deg/rad and -180-180 vs. 0-360 in CLM input files.. #89

ekluzek opened this issue Dec 16, 2017 · 1 comment
Labels
bug something is working incorrectly priority: low Background task that doesn't need to be done right away.

Comments

@ekluzek
Copy link
Collaborator

ekluzek commented Dec 16, 2017

Erik Kluzek < erik > - 2012-01-20 10:22:36 -0700
Bugzilla Id: 1451
Bugzilla CC: anthony.p.craig, dlawren, higginsm, mvertens, rfisher, sacks,

Matt found problems with handling of input files in CLM when in radians instead of degrees, and also for files on -180-180 versus 0-360. Previously I made sure all input files in CLM where 0-360 and in degree's as there were problems otherwise. There's also quite a few files here to think about. surface datasets, domain files, mapping files (both for model and for mksurdata_map), nitrogen-deposition and aerosol deposition files. I'm not sure if the entire modelling system can handle it if different parts of these files are on different grids or not. I believe all raw datasets for mksurfdata_map are on -180-180. If we create domain files on 0-360 does the mapping still work right? And if we create surface datasets on -180-180, do the aerosol and Nitrogen deposition files still work right?

CLM can certainly check that the input units are degrees and die if not. Or really converting between the two isn't a real issue. I'm NOT sure about the -180-180 conversion though...
@ekluzek ekluzek added this to the clm5 milestone Dec 16, 2017
@ekluzek ekluzek added the priority: low Background task that doesn't need to be done right away. label Dec 16, 2017
@ekluzek
Copy link
Collaborator Author

ekluzek commented Dec 16, 2017

Erik Kluzek < erik > - 2012-07-09 15:10:19 -0600

In clm4_0_44, Tony added a change that fixes a specific manifestation of this problem for the grid domain that was needed for WRF files. It only handles one case, but does allow more of this than was allowed before (which was zero).

@ekluzek ekluzek removed this from the clm5 milestone Aug 26, 2019
@billsacks billsacks added the bug something is working incorrectly label Aug 26, 2019
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@ekluzek
Hardcode the align year to prevent the problem in ESCOMP#89, this isn…
c15126b 
…'t the best way to do this especially for the cases with multiple years, which you'll want the user to be able to customize
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@jedwards4b
Merge pull request ESCOMP#88 from jedwards4b/streams_improvement
b85dcd0 
### Description of changes
Improve support for user mods in *.streams.xml file.  If the file is found in the run directory it will be used for that data components streams.  I have added an xsd file as well to use with xmllint to assure the syntax of the file.  Due to namelist change in cmeps for multiple ice sheets all namelists changed and so new baselines, may12, were generated.  

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #): ESCOMP#79 

Are there dependencies on other component PRs
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [X] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 

Any User Interface Changes (namelist or namelist defaults changes)?
 - [X] Yes Indirectly due to changes in glc (multiple ice sheet support)
 - [ ] No

Testing performed:
- [X] (required) aux_cdeps
   - machines and compilers: cheyenne intel 
   - details (e.g. failed tests): see issue ESCOMP#89 
- [ ] (optional) CESM prealpha test
   - machines and compilers
   - details (e.g. failed tests):

Hashes used for testing:
- [X] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: 353730e
- [X] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: master
  - hash: cf0d47ba
- [ ] CESM
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - branch: nuopc_dev
  - hash:
samsrabin pushed a commit to samsrabin/CTSM that referenced this issue Apr 19, 2024
@jedwards4b
Merge pull request ESCOMP#92 from ekluzek/fixalignyear
35de2cb 
### Description of changes

Fix the align year issue. Fix a total of three issues.

### Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):
 Fixes ESCOMP#86
 Fixes ESCOMP#89 
 Fixes ESCOMP#91 

Are there dependencies on other component PRs: No
 - [ ] CIME (list)
 - [ ] CMEPS (list) 

Are changes expected to change answers?
 - [ x] bit for bit
 - [ ] different at roundoff level
 - [ ] more substantial 
Technically tests with the 1PT sites will be different because the start date is different.

Any User Interface Changes (namelist or namelist defaults changes)?
 - [ ] Yes
 - [ x] No
 
The one caveat is that now $DATM_YR is enabled to work for the 1PT sites

Testing performed:
- [ x] (required) aux_cdeps
   - machines and compilers:  cheyenne_intel
   - failed tests: Since I tested in a CTSM checkout the DLND test fails as expected, but as no changes to dlnd this shouldn't matter:
SMS_Vnuopc_Ld3.f09_f09_mg17.1850_SATM_DLND%SCPL_SICE_SOCN_SROF_SGLC_SWAV.cheyenne_intel

Hashes used for testing:
- [ ] CIME
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - tag: cime5.8.47
- [ ] CMEPS
  - repository to check out: https://github.com/ESCOMP/CESM.git
  - tag; v0.10.0
- [ ] CTSM
  - repository to check out: https://github.com/jedwards4b/CESM.git
  - branch: neon_compsets
  - hash: ctsm5.1.dev038-43-gd43264c75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug something is working incorrectly priority: low Background task that doesn't need to be done right away.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@billsacks @ekluzek